Commit 969bf687 authored Aug 27, 2025 by Claudiu Beznea Committed by Vinod Koul Sep 01, 2025

soundwire: bus: Drop dev_pm_domain_detach() call



Starting with commit f9950807 ("PM: domains: Detach on
device_unbind_cleanup()"), there is no longer a need to call
dev_pm_domain_detach() in the bus remove function. The
device_unbind_cleanup() function now handles this to avoid
invoking devres cleanup handlers while the PM domain is
powered off, which could otherwise lead to failures as
described in the above-mentioned commit.

Drop the explicit dev_pm_domain_detach() call and rely instead
on the flags passed to dev_pm_domain_attach() to power off the
domain.

Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Link: https://lore.kernel.org/r/20250827101506.927787-1-claudiu.beznea.uj@bp.renesas.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 8b63fee9

drivers/soundwire/bus_type.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -114,7 +114,6 @@ static int sdw_drv_probe(struct device *dev)

		ret = drv->probe(slave, id);
		if (ret) {
		dev_pm_domain_detach(dev, false);
		ida_free(&slave->bus->slave_ida, slave->index);
		return ret;
		}
		@@ -180,8 +179,6 @@ static int sdw_drv_remove(struct device *dev)
		if (drv->remove)
		ret = drv->remove(slave);

		dev_pm_domain_detach(dev, false);

		ida_free(&slave->bus->slave_ida, slave->index);

		return ret;