Commit 969c3cca authored by Andreas Gabriel-Platschek's avatar Andreas Gabriel-Platschek Committed by Alexandre Belloni
Browse files

rtc: ds1390: fix number of bytes read from RTC 



The spi_write_then_read() reads 8 bytes starting from
DS1390_REG_SECONDS (== 0x01), so the last byte read would already
be part of the alarm (Tenths and Hundredths of Seconds) feature.

However 7 bytes are engouh -- seconds (0x01), minutes (0x02), hours (0x03),
day (0x04), date (0x05), month/century (0x06) and year (0x07).

Signed-off-by: default avatarAndreas Gabriel-Platschek <andi.platschek@gmail.com>
Link: https://patch.msgid.link/20260209053439.313825-1-andi.platschek@gmail.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 76e8919a

drivers/rtc/rtc-ds1390.c

+1 −1
Original line number Diff line number Diff line
@@ -134,7 +134,7 @@ static int ds1390_read_time(struct device *dev, struct rtc_time *dt) 
	chip->txrx_buf[0] = DS1390_REG_SECONDS;



	/* do the i/o */

	status = spi_write_then_read(spi, chip->txrx_buf, 1, chip->txrx_buf, 8);

	status = spi_write_then_read(spi, chip->txrx_buf, 1, chip->txrx_buf, 7);

	if (status != 0)

		return status;