Commit 96d566b6 authored by Markus Elfring's avatar Markus Elfring Committed by Steve French
Browse files

smb3: Improve exception handling in allocate_mr_list() 



The kfree() function was called in one case by
the allocate_mr_list() function during error handling
even if the passed variable contained a null pointer.
This issue was detected by using the Coccinelle software.

Thus use another label.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 516eea97

fs/smb/client/smbdirect.c

+2 −2
Original line number Diff line number Diff line
@@ -2136,7 +2136,7 @@ static int allocate_mr_list(struct smbd_connection *info) 
	for (i = 0; i < info->responder_resources * 2; i++) {

		smbdirect_mr = kzalloc(sizeof(*smbdirect_mr), GFP_KERNEL);

		if (!smbdirect_mr)

			goto out;

			goto cleanup_entries;

		smbdirect_mr->mr = ib_alloc_mr(info->pd, info->mr_type,

					info->max_frmr_depth);

		if (IS_ERR(smbdirect_mr->mr)) {
@@ -2162,7 +2162,7 @@ static int allocate_mr_list(struct smbd_connection *info) 


out:

	kfree(smbdirect_mr);



cleanup_entries:

	list_for_each_entry_safe(smbdirect_mr, tmp, &info->mr_list, list) {

		list_del(&smbdirect_mr->list);

		ib_dereg_mr(smbdirect_mr->mr);