Commit 9709b56d authored by Alexander Koskovich's avatar Alexander Koskovich Committed by Paolo Abeni
Browse files

net: ipa: fix GENERIC_CMD register field masks for IPA v5.0+ 



Fix the field masks to match the hardware layout documented in
downstream GSI (GSI_V3_0_EE_n_GSI_EE_GENERIC_CMD_*).

Notably this fixes a WARN I was seeing when I tried to send "stop"
to the MPSS remoteproc while IPA was up.

Fixes: faf0678e ("net: ipa: add IPA v5.0 GSI register definitions")
Signed-off-by: default avatarAlexander Koskovich <akoskovich@pm.me>
Signed-off-by: default avatarLuca Weiss <luca.weiss@fairphone.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260403-milos-ipa-v1-1-01e9e4e03d3e@fairphone.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 2607c090

drivers/net/ipa/reg/gsi_reg-v5.0.c

+4 −3
Original line number Diff line number Diff line
@@ -156,9 +156,10 @@ REG_FIELDS(EV_CH_CMD, ev_ch_cmd, 0x00025010 + 0x12000 * GSI_EE_AP); 


static const u32 reg_generic_cmd_fmask[] = {

	[GENERIC_OPCODE]				= GENMASK(4, 0),

	[GENERIC_CHID]					= GENMASK(9, 5),

	[GENERIC_EE]					= GENMASK(13, 10),

						/* Bits 14-31 reserved */

	[GENERIC_CHID]					= GENMASK(12, 5),

	[GENERIC_EE]					= GENMASK(16, 13),

						/* Bits 17-23 reserved */

	[GENERIC_PARAMS]				= GENMASK(31, 24),

};



REG_FIELDS(GENERIC_CMD, generic_cmd, 0x00025018 + 0x12000 * GSI_EE_AP);