Commit 970ae863 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo Committed by Namhyung Kim
Browse files

perf build: The bfd features are opt-in, stop testing for them by default 



These are leftovers noticed while updating a build container.

We don't need those so that test-all.c can build and thus speed up the
feature detection.

Test for those features only if the user asks for BUILD_NONDISTRO=1 to
build with libbfd.

Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Reviewed-by: default avatarJames Clark <james.clark@linaro.org>
Reviewed-by: default avatarIan Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250620212435.93846-4-acme@kernel.org


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent 7c750d39

tools/build/feature/test-all.c

+0 −19
Original line number Diff line number Diff line
@@ -66,14 +66,6 @@ 
# include "test-libslang.c"

#undef main



#define main main_test_libbfd

# include "test-libbfd.c"

#undef main



#define main main_test_libbfd_buildid

# include "test-libbfd-buildid.c"

#undef main



#define main main_test_backtrace

# include "test-backtrace.c"

#undef main
@@ -158,14 +150,6 @@ 
# include "test-reallocarray.c"

#undef main



#define main main_test_disassembler_four_args

# include "test-disassembler-four-args.c"

#undef main



#define main main_test_disassembler_init_styled

# include "test-disassembler-init-styled.c"

#undef main



#define main main_test_libzstd

# include "test-libzstd.c"

#undef main
@@ -193,8 +177,6 @@ int main(int argc, char *argv[]) 
	main_test_libelf_gelf_getnote();

	main_test_libelf_getshdrstrndx();

	main_test_libslang();

	main_test_libbfd();

	main_test_libbfd_buildid();

	main_test_backtrace();

	main_test_libnuma();

	main_test_numa_num_possible_cpus();
@@ -213,7 +195,6 @@ int main(int argc, char *argv[]) 
	main_test_setns();

	main_test_libaio();

	main_test_reallocarray();

	main_test_disassembler_four_args();

	main_test_libzstd();

	main_test_libtraceevent();

	main_test_libtracefs();

tools/perf/Makefile.config

+5 −0
Original line number Diff line number Diff line
@@ -926,6 +926,8 @@ ifneq ($(NO_JEVENTS),1) 
endif



ifdef BUILD_NONDISTRO

  $(call feature_check,libbfd)



  ifeq ($(feature-libbfd), 1)

    EXTLIBS += -lbfd -lopcodes

  else
@@ -954,6 +956,9 @@ ifdef BUILD_NONDISTRO 


  CFLAGS += -DHAVE_LIBBFD_SUPPORT

  CXXFLAGS += -DHAVE_LIBBFD_SUPPORT



  $(call feature_check,libbfd-buildid)



  ifeq ($(feature-libbfd-buildid), 1)

    CFLAGS += -DHAVE_LIBBFD_BUILDID_SUPPORT

  else