Unverified Commit 97110d42 authored by Damien Le Moal's avatar Damien Le Moal Committed by Krzysztof Wilczyński
Browse files

PCI: endpoint: test: Synchronously cancel command handler work 

Use cancel_delayed_work_sync() in pci_epf_test_epc_deinit() to ensure
that the command handler is really stopped before proceeding with DMA
and BAR cleanup.

The same change is also done in pci_epf_test_link_down() to ensure that
the link down handling completes with the command handler fully stopped.

Link: https://lore.kernel.org/r/20241017010648.189889-1-dlemoal@kernel.org


Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
parent e73ea1c2

drivers/pci/endpoint/functions/pci-epf-test.c

+2 −2
Original line number Diff line number Diff line
@@ -800,7 +800,7 @@ static void pci_epf_test_epc_deinit(struct pci_epf *epf) 
{

	struct pci_epf_test *epf_test = epf_get_drvdata(epf);



	cancel_delayed_work(&epf_test->cmd_handler);

	cancel_delayed_work_sync(&epf_test->cmd_handler);

	pci_epf_test_clean_dma_chan(epf_test);

	pci_epf_test_clear_bar(epf);

}
@@ -931,7 +931,7 @@ static void pci_epf_test_unbind(struct pci_epf *epf) 
	struct pci_epf_test *epf_test = epf_get_drvdata(epf);

	struct pci_epc *epc = epf->epc;



	cancel_delayed_work(&epf_test->cmd_handler);

	cancel_delayed_work_sync(&epf_test->cmd_handler);

	if (epc->init_complete) {

		pci_epf_test_clean_dma_chan(epf_test);

		pci_epf_test_clear_bar(epf);