Commit 9736c648 authored by Jiri Pirko's avatar Jiri Pirko Committed by Jakub Kicinski
Browse files

dpll: check that pin is registered in __dpll_pin_unregister() 



Similar to what is done in dpll_device_unregister(), add assertion to
__dpll_pin_unregister() to make sure driver does not try to unregister
non-registered pin.

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarVadim Fedorenko <vadim.fedorenko@linux.dev>
Reviewed-by: default avatarArkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Link: https://lore.kernel.org/r/20240206074853.345744-1-jiri@resnulli.us


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c474dd5a

drivers/dpll/dpll_core.c

+3 −0
Original line number Diff line number Diff line
@@ -29,6 +29,8 @@ static u32 dpll_pin_xa_id; 
	WARN_ON_ONCE(!xa_get_mark(&dpll_device_xa, (d)->id, DPLL_REGISTERED))

#define ASSERT_DPLL_NOT_REGISTERED(d)	\

	WARN_ON_ONCE(xa_get_mark(&dpll_device_xa, (d)->id, DPLL_REGISTERED))

#define ASSERT_DPLL_PIN_REGISTERED(p) \

	WARN_ON_ONCE(!xa_get_mark(&dpll_pin_xa, (p)->id, DPLL_REGISTERED))



struct dpll_device_registration {

	struct list_head list;
@@ -631,6 +633,7 @@ static void 
__dpll_pin_unregister(struct dpll_device *dpll, struct dpll_pin *pin,

		      const struct dpll_pin_ops *ops, void *priv)

{

	ASSERT_DPLL_PIN_REGISTERED(pin);

	dpll_xa_ref_pin_del(&dpll->pin_refs, pin, ops, priv);

	dpll_xa_ref_dpll_del(&pin->dpll_refs, dpll, ops, priv);

	if (xa_empty(&pin->dpll_refs))