Commit 9739d583 authored by Lukasz Czapnik's avatar Lukasz Czapnik Committed by Tony Nguyen
Browse files

i40e: fix input validation logic for action_meta 



Fix condition to check 'greater or equal' to prevent OOB dereference.

Fixes: e284fc28 ("i40e: Add and delete cloud filter")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarLukasz Czapnik <lukasz.czapnik@intel.com>
Reviewed-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Tested-by: default avatarRafal Romanowski <rafal.romanowski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent f1ad24c5

drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

+1 −1
Original line number Diff line number Diff line
@@ -3603,7 +3603,7 @@ static int i40e_validate_cloud_filter(struct i40e_vf *vf, 


	/* action_meta is TC number here to which the filter is applied */

	if (!tc_filter->action_meta ||

	    tc_filter->action_meta > vf->num_tc) {

	    tc_filter->action_meta >= vf->num_tc) {

		dev_info(&pf->pdev->dev, "VF %d: Invalid TC number %u\n",

			 vf->vf_id, tc_filter->action_meta);

		goto err;