Commit 9759ae2c authored by Lu Baolu's avatar Lu Baolu Committed by Joerg Roedel
Browse files

iommu: Fix potential memory leak in iopf_queue_remove_device() 



The iopf_queue_remove_device() helper removes a device from the per-iommu
iopf queue when PRI is disabled on the device. It responds to all
outstanding iopf's with an IOMMU_PAGE_RESP_INVALID code and detaches the
device from the queue.

However, it fails to release the group structure that represents a group
of iopf's awaiting for a response after responding to the hardware. This
can cause a memory leak if iopf_queue_remove_device() is called with
pending iopf's.

Fix it by calling iopf_free_group() after the iopf group is responded.

Fixes: 19911232 ("iommu: Track iopf group instead of last fault")
Cc: stable@vger.kernel.org
Suggested-by: default avatarKevin Tian <kevin.tian@intel.com>
Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20250117055800.782462-1-baolu.lu@linux.intel.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent a64dcfb4

drivers/iommu/io-pgfault.c

+1 −0
Original line number Diff line number Diff line
@@ -478,6 +478,7 @@ void iopf_queue_remove_device(struct iopf_queue *queue, struct device *dev) 


		ops->page_response(dev, iopf, &resp);

		list_del_init(&group->pending_node);

		iopf_free_group(group);

	}

	mutex_unlock(&fault_param->lock);