Commit 977b9481 authored by Jakob Koschel's avatar Jakob Koschel Committed by Greg Kroah-Hartman
Browse files

usb: gadget: udc: s3c2410: remove usage of list iterator past the loop body 

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable [1].

Link: https://lore.kernel.org/all/YhdfEIwI4EdtHdym@kroah.com/


Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: default avatarJakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220308171818.384491-27-jakobkoschel@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7975f080

drivers/usb/gadget/udc/s3c2410_udc.c

+9 −8
Original line number Diff line number Diff line
@@ -1265,7 +1265,7 @@ static int s3c2410_udc_dequeue(struct usb_ep *_ep, struct usb_request *_req) 
	struct s3c2410_ep	*ep = to_s3c2410_ep(_ep);

	int			retval = -EINVAL;

	unsigned long		flags;

	struct s3c2410_request	*req = NULL;

	struct s3c2410_request	*req = NULL, *iter;



	dprintk(DEBUG_VERBOSE, "%s(%p,%p)\n", __func__, _ep, _req);
@@ -1277,14 +1277,15 @@ static int s3c2410_udc_dequeue(struct usb_ep *_ep, struct usb_request *_req) 


	local_irq_save(flags);



	list_for_each_entry(req, &ep->queue, queue) {

		if (&req->req == _req) {

			list_del_init(&req->queue);

	list_for_each_entry(iter, &ep->queue, queue) {

		if (&iter->req != _req)

			continue;

		list_del_init(&iter->queue);

		_req->status = -ECONNRESET;

		req = iter;

		retval = 0;

		break;

	}

	}



	if (retval == 0) {

		dprintk(DEBUG_VERBOSE,