Commit 97b6b4ac authored by Ian Rogers's avatar Ian Rogers Committed by Namhyung Kim
Browse files

perf metrics: Fix segv for metrics with no events 



A metric may have no events, for example, the transaction metrics on
x86 are dependent on there being TSX events. Fix a segv where an evsel
of NULL is dereferenced for a metric leader value.

Fixes: a59fb796 ("perf metrics: Compute unmerged uncore metrics individually")
Signed-off-by: default avatarIan Rogers <irogers@google.com>
Reviewed-by: default avatarKan Liang <kan.liang@linux.intel.com>
Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240224011420.3066322-2-irogers@google.com
parent d4be39ca

tools/perf/util/metricgroup.c

+1 −1
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@ struct metric_event *metricgroup__lookup(struct rblist *metric_events, 
	if (!metric_events)

		return NULL;



	if (evsel->metric_leader)

	if (evsel && evsel->metric_leader)

		me.evsel = evsel->metric_leader;

	nd = rblist__find(metric_events, &me);

	if (nd)