Unverified Commit 97b726eb authored by Armin Wolf's avatar Armin Wolf Committed by Ilpo Järvinen
Browse files

platform/x86: msi-wmi-platform: Fix typo in WMI GUID 



The WMI driver core only supports GUID strings containing only
uppercase characters, however the GUID string used by the
msi-wmi-platform driver contains a single lowercase character.
This prevents the WMI driver core from matching said driver to
its WMI device.

Fix this by turning the lowercase character into a uppercase
character. Also update the WMI driver development guide to warn
about this.

Reported-by: default avatarAntheas Kapenekakis <lkml@antheas.dev>
Fixes: 9c0beb6b ("platform/x86: wmi: Add MSI WMI Platform driver")
Tested-by: default avatarAntheas Kapenekakis <lkml@antheas.dev>
Signed-off-by: default avatarArmin Wolf <W_Armin@gmx.de>
Link: https://patch.msgid.link/20251110111253.16204-3-W_Armin@gmx.de


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent c93433fd

Documentation/wmi/driver-development-guide.rst

+1 −0
Original line number Diff line number Diff line
@@ -54,6 +54,7 @@ to matching WMI devices using a struct wmi_device_id table: 
::



  static const struct wmi_device_id foo_id_table[] = {

         /* Only use uppercase letters! */

         { "936DA01F-9ABD-4D9D-80C7-02AF85C822A8", NULL },

         { }

  };

drivers/platform/x86/msi-wmi-platform.c

+1 −1
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ 


#define DRIVER_NAME	"msi-wmi-platform"



#define MSI_PLATFORM_GUID	"ABBC0F6E-8EA1-11d1-00A0-C90629100000"

#define MSI_PLATFORM_GUID	"ABBC0F6E-8EA1-11D1-00A0-C90629100000"



#define MSI_WMI_PLATFORM_INTERFACE_VERSION	2