Commit 97c55c12 authored by Inochi Amaoto's avatar Inochi Amaoto Committed by Jakub Kicinski
Browse files

net: ethernet: litex: use devm_register_netdev() to register netdev 



Use devm_register_netdev to avoid unnecessary remove() callback in
platform_driver structure.

Signed-off-by: default avatarInochi Amaoto <inochiama@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260227003351.752934-2-inochiama@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 57cc8ab3

drivers/net/ethernet/litex/litex_liteeth.c

+2 −9
Original line number Diff line number Diff line
@@ -232,6 +232,7 @@ static void liteeth_setup_slots(struct liteeth *priv) 


static int liteeth_probe(struct platform_device *pdev)

{

	struct device *dev = &pdev->dev;

	struct net_device *netdev;

	void __iomem *buf_base;

	struct liteeth *priv;
@@ -282,7 +283,7 @@ static int liteeth_probe(struct platform_device *pdev) 


	netdev->netdev_ops = &liteeth_netdev_ops;



	err = register_netdev(netdev);

	err = devm_register_netdev(dev, netdev);

	if (err) {

		dev_err(&pdev->dev, "Failed to register netdev %d\n", err);

		return err;
@@ -294,13 +295,6 @@ static int liteeth_probe(struct platform_device *pdev) 
	return 0;

}



static void liteeth_remove(struct platform_device *pdev)

{

	struct net_device *netdev = platform_get_drvdata(pdev);



	unregister_netdev(netdev);

}



static const struct of_device_id liteeth_of_match[] = {

	{ .compatible = "litex,liteeth" },

	{ }
@@ -309,7 +303,6 @@ MODULE_DEVICE_TABLE(of, liteeth_of_match); 


static struct platform_driver liteeth_driver = {

	.probe = liteeth_probe,

	.remove = liteeth_remove,

	.driver = {

		.name = DRV_NAME,

		.of_match_table = liteeth_of_match,