Commit 97e8a2ff authored by Stefan Eichenberger's avatar Stefan Eichenberger Committed by Vinod Koul
Browse files

phy: freescale: imx8m-pcie: cleanup reset logic 



Remove the switch statement and base perst release on whether it is
found in the device tree. The probe function fails without the reset
property, making it mandatory. Therefore, always release reset
independent of the variant.

This does not change the behavior of the driver but reduces driver
complexity and allows for easier future modifications.

Signed-off-by: default avatarStefan Eichenberger <stefan.eichenberger@toradex.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250305144355.20364-2-eichest@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent b02d41d8

drivers/phy/freescale/phy-fsl-imx8m-pcie.c

+3 −9
Original line number Diff line number Diff line
@@ -141,15 +141,9 @@ static int imx8_pcie_phy_power_on(struct phy *phy) 
			   IMX8MM_GPR_PCIE_REF_CLK_PLL);

	usleep_range(100, 200);



	switch (imx8_phy->drvdata->variant) {

	case IMX8MP:

	reset_control_deassert(imx8_phy->perst);

		fallthrough;

	case IMX8MM:

	reset_control_deassert(imx8_phy->reset);

	usleep_range(200, 500);

		break;

	}



	/* Do the PHY common block reset */

	regmap_update_bits(imx8_phy->iomuxc_gpr, IOMUXC_GPR14,