Commit 97f4b999 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq: Use scoped_guard() to shut clang up 



This code pattern trips clang up:

     if (fail)
     	goto undo;

     guard(lock)(lock);
     do_stuff();
     return 0;

undo:
     ...

as it somehow extends the scope of the guard beyond the return statement.

Replace it with a scoped guard to help it to get its act together.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Closes: https://lore.kernel.org/oe-kbuild-all/202505071809.ajpPxfoZ-lkp@intel.com/
parent aefc1155

kernel/irq/manage.c

+2 −2
Original line number Diff line number Diff line
@@ -2564,7 +2564,7 @@ int request_percpu_nmi(unsigned int irq, irq_handler_t handler, 
	if (retval)

		goto err_irq_setup;



	guard(raw_spinlock_irqsave)(&desc->lock);

	scoped_guard(raw_spinlock_irqsave, &desc->lock)

		desc->istate |= IRQS_NMI;

	return 0;