Commit 9806f283 authored by Andrii Nakryiko's avatar Andrii Nakryiko Committed by Alexei Starovoitov
Browse files

bpf: fix do_misc_fixups() for bpf_get_branch_snapshot() 



We need `goto next_insn;` at the end of patching instead of `continue;`.
It currently works by accident by making verifier re-process patched
instructions.

Reported-by: default avatarShung-Hsi Yu <shung-hsi.yu@suse.com>
Fixes: 314a5362 ("bpf: inline bpf_get_branch_snapshot() helper")
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Acked-by: default avatarYonghong Song <yonghong.song@linux.dev>
Acked-by: default avatarShung-Hsi Yu <shung-hsi.yu@suse.com>
Link: https://lore.kernel.org/r/20241023161916.2896274-1-andrii@kernel.org


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 0ee288e6

kernel/bpf/verifier.c

+1 −1
Original line number Diff line number Diff line
@@ -21210,7 +21210,7 @@ static int do_misc_fixups(struct bpf_verifier_env *env) 
			delta    += cnt - 1;

			env->prog = prog = new_prog;

			insn      = new_prog->insnsi + i + delta;

			continue;

			goto next_insn;

		}









		/* Implement bpf_kptr_xchg inline */