Commit 980ce2b0 authored by Zilin Guan's avatar Zilin Guan Committed by Miquel Raynal
Browse files

mtd: parsers: Fix memory leak in mtd_parser_tplink_safeloader_parse() 



The function mtd_parser_tplink_safeloader_parse() allocates buf via
mtd_parser_tplink_safeloader_read_table(). If the allocation for
parts[idx].name fails inside the loop, the code jumps to the err_free
label without freeing buf, leading to a memory leak.

Fix this by freeing the temporary buffer buf in the err_free label.

Compile tested only. Issue found using a prototype static analysis tool
and code review.

Fixes: 00a35880 ("mtd: parsers: add TP-Link SafeLoader partitions table parser")
Signed-off-by: default avatarZilin Guan <zilin@seu.edu.cn>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent 125981ff

drivers/mtd/parsers/tplink_safeloader.c

+1 −0
Original line number Diff line number Diff line
@@ -116,6 +116,7 @@ static int mtd_parser_tplink_safeloader_parse(struct mtd_info *mtd, 
	return idx;



err_free:

	kfree(buf);

	for (idx -= 1; idx >= 0; idx--)

		kfree(parts[idx].name);

err_free_parts: