Commit 981b696f authored by Xichao Zhao's avatar Xichao Zhao Committed by Theodore Ts'o
Browse files

ext4: replace min/max nesting with clamp() 



The clamp() macro explicitly expresses the intent of constraining a value
within bounds.Therefore, replacing max(min(a,b),c) with clamp(val, lo, hi)
can improve code readability.

Signed-off-by: default avatarXichao Zhao <zhao.xichao@vivo.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 1534f72d

fs/ext4/mmp.c

+3 −3
Original line number Diff line number Diff line
@@ -231,9 +231,9 @@ static int kmmpd(void *data) 
		 * Adjust the mmp_check_interval depending on how much time

		 * it took for the MMP block to be written.

		 */

		mmp_check_interval = max(min(EXT4_MMP_CHECK_MULT * diff / HZ,

					     EXT4_MMP_MAX_CHECK_INTERVAL),

					 EXT4_MMP_MIN_CHECK_INTERVAL);

		mmp_check_interval = clamp(EXT4_MMP_CHECK_MULT * diff / HZ,

					   EXT4_MMP_MIN_CHECK_INTERVAL,

					   EXT4_MMP_MAX_CHECK_INTERVAL);

		mmp->mmp_check_interval = cpu_to_le16(mmp_check_interval);

	}