Commit 98236343 authored by Marco Crivellari's avatar Marco Crivellari Committed by Jens Axboe
Browse files

block: Add WQ_PERCPU to alloc_workqueue users 

This continues the effort to refactor workqueue APIs, which began with
the introduction of new workqueues and a new alloc_workqueue flag in:

   commit 128ea9f6 ("workqueue: Add system_percpu_wq and system_dfl_wq")
   commit 930c2ea5 ("workqueue: Add new WQ_PERCPU flag")

The refactoring is going to alter the default behavior of
alloc_workqueue() to be unbound by default.

With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU. For more details see the Link tag below.

In order to keep alloc_workqueue() behavior identical, explicitly request
WQ_PERCPU.

Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/


Suggested-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarMarco Crivellari <marco.crivellari@suse.com>
Link: https://patch.msgid.link/20260223092920.60424-2-marco.crivellari@suse.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 41c665aa

block/bio-integrity-auto.c

+1 −1
Original line number Diff line number Diff line
@@ -125,7 +125,7 @@ static int __init blk_integrity_auto_init(void) 
	 * Make it highpri CPU intensive wq with max concurrency of 1.

	 */

	kintegrityd_wq = alloc_workqueue("kintegrityd", WQ_MEM_RECLAIM |

					 WQ_HIGHPRI | WQ_CPU_INTENSIVE, 1);

					 WQ_HIGHPRI | WQ_CPU_INTENSIVE | WQ_PERCPU, 1);

	if (!kintegrityd_wq)

		panic("Failed to create kintegrityd\n");

	return 0;

block/bio.c

+1 −1
Original line number Diff line number Diff line
@@ -1958,7 +1958,7 @@ int bioset_init(struct bio_set *bs, 


	if (flags & BIOSET_NEED_RESCUER) {

		bs->rescue_workqueue = alloc_workqueue("bioset",

							WQ_MEM_RECLAIM, 0);

							WQ_MEM_RECLAIM | WQ_PERCPU, 0);

		if (!bs->rescue_workqueue)

			goto bad;

	}

block/blk-core.c

+1 −1
Original line number Diff line number Diff line
@@ -1282,7 +1282,7 @@ int __init blk_dev_init(void) 


	/* used for unplugging and affects IO latency/throughput - HIGHPRI */

	kblockd_workqueue = alloc_workqueue("kblockd",

					    WQ_MEM_RECLAIM | WQ_HIGHPRI, 0);

					    WQ_MEM_RECLAIM | WQ_HIGHPRI | WQ_PERCPU, 0);

	if (!kblockd_workqueue)

		panic("Failed to create kblockd\n");