Commit 9854b243 authored by Gal Pressman's avatar Gal Pressman Committed by Jakub Kicinski
Browse files

net/mlx5e: MACsec, add ASO poll loop in macsec_aso_set_arm_event 



The macsec_aso_set_arm_event function calls mlx5_aso_poll_cq once
without a retry loop. If the CQE is not immediately available after
posting the WQE, the function fails unnecessarily.

Use read_poll_timeout() to poll 3-10 usecs for CQE, consistent with
other ASO polling code paths in the driver.

Fixes: 739cfa34 ("net/mlx5: Make ASO poll CQ usable in atomic context")
Signed-off-by: default avatarGal Pressman <gal@nvidia.com>
Reviewed-by: default avatarJianbo Liu <jianbol@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Reviewed-by: default avatarJacob Keller <Jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20260218072904.1764634-5-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d451994e

drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c

+2 −1
Original line number Diff line number Diff line
@@ -1386,7 +1386,8 @@ static int macsec_aso_set_arm_event(struct mlx5_core_dev *mdev, struct mlx5e_mac 
			   MLX5_ACCESS_ASO_OPC_MOD_MACSEC);

	macsec_aso_build_ctrl(aso, &aso_wqe->aso_ctrl, in);

	mlx5_aso_post_wqe(maso, false, &aso_wqe->ctrl);

	err = mlx5_aso_poll_cq(maso, false);

	read_poll_timeout(mlx5_aso_poll_cq, err, !err, 10, 10 * USEC_PER_MSEC,

			  false, maso, false);

	mutex_unlock(&aso->aso_lock);



	return err;