Commit 9882f121 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: stmmac: lpc18xx: use stmmac_get_phy_intf_sel() 



Use stmmac_get_phy_intf_sel() to decode the PHY interface mode to the
phy_intf_sel value, and use the result to program the ethernet mode.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1vGy5J-0000000DhQD-46Ob@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent eb0533c7

drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c

+4 −5
Original line number Diff line number Diff line
@@ -47,15 +47,14 @@ static int lpc18xx_dwmac_probe(struct platform_device *pdev) 
		return PTR_ERR(reg);

	}



	if (plat_dat->phy_interface == PHY_INTERFACE_MODE_MII) {

		ethmode = PHY_INTF_SEL_GMII_MII;

	} else if (plat_dat->phy_interface == PHY_INTERFACE_MODE_RMII) {

		ethmode = PHY_INTF_SEL_RMII;

	} else {

	if (plat_dat->phy_interface != PHY_INTERFACE_MODE_MII &&

	    plat_dat->phy_interface != PHY_INTERFACE_MODE_RMII) {

		dev_err(&pdev->dev, "Only MII and RMII mode supported\n");

		return -EINVAL;

	}



	ethmode = stmmac_get_phy_intf_sel(plat_dat->phy_interface);



	regmap_update_bits(reg, LPC18XX_CREG_CREG6,

			   LPC18XX_CREG_CREG6_ETHMODE_MASK, ethmode);