Commit 98a953fa authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Bjorn Andersson
Browse files

arm64: dts: qcom: sm8550: Fix the msi-map entries 



While adding the GIC ITS MSI support, it was found that the msi-map entries
needed to be swapped to receive MSIs from the endpoint.

But later it was identified that the swapping was needed due to a bug in
the Qualcomm PCIe controller driver. And since the bug is now fixed with
commit bf79e33c ("PCI: qcom: Enable BDF to SID translation properly"),
let's fix the msi-map entries also to reflect the actual mapping in the
hardware.

Fixes: 114990ce ("arm64: dts: qcom: sm8550: Use GIC-ITS for PCIe0 and PCIe1")
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
Link: https://lore.kernel.org/r/20240318-pci-bdf-sid-fix-v1-2-acca6c5d9cf1@linaro.org


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent ecc3ac29

arch/arm64/boot/dts/qcom/sm8550.dtsi

+4 −6
Original line number Diff line number Diff line
@@ -1755,9 +1755,8 @@ pcie0: pcie@1c00000 { 
					<&gem_noc MASTER_APPSS_PROC 0 &cnoc_main SLAVE_PCIE_0 0>;

			interconnect-names = "pcie-mem", "cpu-pcie";



			/* Entries are reversed due to the unusual ITS DeviceID encoding */

			msi-map = <0x0 &gic_its 0x1401 0x1>,

				  <0x100 &gic_its 0x1400 0x1>;

			msi-map = <0x0 &gic_its 0x1400 0x1>,

				  <0x100 &gic_its 0x1401 0x1>;

			iommu-map = <0x0   &apps_smmu 0x1400 0x1>,

				    <0x100 &apps_smmu 0x1401 0x1>;
@@ -1867,9 +1866,8 @@ pcie1: pcie@1c08000 { 
					<&gem_noc MASTER_APPSS_PROC 0 &cnoc_main SLAVE_PCIE_1 0>;

			interconnect-names = "pcie-mem", "cpu-pcie";



			/* Entries are reversed due to the unusual ITS DeviceID encoding */

			msi-map = <0x0 &gic_its 0x1481 0x1>,

				  <0x100 &gic_its 0x1480 0x1>;

			msi-map = <0x0 &gic_its 0x1480 0x1>,

				  <0x100 &gic_its 0x1481 0x1>;

			iommu-map = <0x0   &apps_smmu 0x1480 0x1>,

				    <0x100 &apps_smmu 0x1481 0x1>;