Commit 98b7bf54 authored by Li Chen's avatar Li Chen Committed by Jens Axboe
Browse files

loop: fix backing file reference leak on validation error 



loop_change_fd() and loop_configure() call loop_check_backing_file()
to validate the new backing file. If validation fails, the reference
acquired by fget() was not dropped, leaking a file reference.

Fix this by calling fput(file) before returning the error.

Cc: stable@vger.kernel.org
Cc: Markus Elfring <Markus.Elfring@web.de>
CC: Yang Erkun <yangerkun@huawei.com>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Yu Kuai <yukuai1@huaweicloud.com>
Fixes: f5c84eff ("loop: Add sanity check for read/write_iter")
Signed-off-by: default avatarLi Chen <chenl311@chinatelecom.cn>
Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
Reviewed-by: default avatarYang Erkun <yangerkun@huawei.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent e1b1d03c

drivers/block/loop.c

+6 −2
Original line number Diff line number Diff line
@@ -551,8 +551,10 @@ static int loop_change_fd(struct loop_device *lo, struct block_device *bdev, 
		return -EBADF;



	error = loop_check_backing_file(file);

	if (error)

	if (error) {

		fput(file);

		return error;

	}



	/* suppress uevents while reconfiguring the device */

	dev_set_uevent_suppress(disk_to_dev(lo->lo_disk), 1);
@@ -993,8 +995,10 @@ static int loop_configure(struct loop_device *lo, blk_mode_t mode, 
		return -EBADF;



	error = loop_check_backing_file(file);

	if (error)

	if (error) {

		fput(file);

		return error;

	}



	is_loop = is_loop_device(file);