Commit 98c88dc8 authored by Vincent Guittot's avatar Vincent Guittot Committed by Peter Zijlstra
Browse files

sched/fair: Fix pelt clock sync when entering idle 

Samuel and Alex reported regressions of the util_avg of RT rq with
commit 17e3e88e ("sched/fair: Fix pelt lost idle time detection").
It happens that fair is updating and syncing the pelt clock with task one
when pick_next_task_fair() fails to pick a task but before the prev
scheduling class got a chance to update its pelt signals.

Move update_idle_rq_clock_pelt() in set_next_task_idle() which is called
after prev class has been called.

Fixes: 17e3e88e ("sched/fair: Fix pelt lost idle time detection")
Closes: https://lore.kernel.org/all/CAG2KctpO6VKS6GN4QWDji0t92_gNBJ7HjjXrE+6H+RwRXt=iLg@mail.gmail.com/
Closes: https://lore.kernel.org/all/8cf19bf0e0054dcfed70e9935029201694f1bb5a.camel@mediatek.com/


Reported-by: default avatarSamuel Wu <wusamuel@google.com>
Reported-by: default avatarAlex Hoh <Alex.Hoh@mediatek.com>
Signed-off-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: default avatarSamuel Wu <wusamuel@google.com>
Tested-by: default avatarAlex Hoh <Alex.Hoh@mediatek.com>
Link: https://patch.msgid.link/20260121163317.505635-1-vincent.guittot@linaro.org
parent 24d479d2

kernel/sched/fair.c

+0 −6
Original line number Diff line number Diff line
@@ -8995,12 +8995,6 @@ pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf 
			goto again;

	}



	/*

	 * rq is about to be idle, check if we need to update the

	 * lost_idle_time of clock_pelt

	 */

	update_idle_rq_clock_pelt(rq);



	return NULL;

}

kernel/sched/idle.c

+6 −0
Original line number Diff line number Diff line
@@ -468,6 +468,12 @@ static void set_next_task_idle(struct rq *rq, struct task_struct *next, bool fir 
	scx_update_idle(rq, true, true);

	schedstat_inc(rq->sched_goidle);

	next->se.exec_start = rq_clock_task(rq);



	/*

	 * rq is about to be idle, check if we need to update the

	 * lost_idle_time of clock_pelt

	 */

	update_idle_rq_clock_pelt(rq);

}



struct task_struct *pick_task_idle(struct rq *rq, struct rq_flags *rf)