Commit 98df1626 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Douglas Anderson
Browse files

drm/bridge: ti-sn65dsi86: use new GPIO line value setter callbacks 



struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20250610-gpiochip-set-rv-gpu-v1-1-ac0a21e74b71@linaro.org
parent 6526b02e

drivers/gpu/drm/bridge/ti-sn65dsi86.c

+7 −11
Original line number Diff line number Diff line
@@ -1672,24 +1672,20 @@ static int ti_sn_bridge_gpio_get(struct gpio_chip *chip, unsigned int offset) 
	return !!(val & BIT(SN_GPIO_INPUT_SHIFT + offset));

}



static void ti_sn_bridge_gpio_set(struct gpio_chip *chip, unsigned int offset,

static int ti_sn_bridge_gpio_set(struct gpio_chip *chip, unsigned int offset,

				 int val)

{

	struct ti_sn65dsi86 *pdata = gpiochip_get_data(chip);

	int ret;



	if (!test_bit(offset, pdata->gchip_output)) {

		dev_err(pdata->dev, "Ignoring GPIO set while input\n");

		return;

		return -EPERM;

	}



	val &= 1;

	ret = regmap_update_bits(pdata->regmap, SN_GPIO_IO_REG,

	return regmap_update_bits(pdata->regmap, SN_GPIO_IO_REG,

				  BIT(SN_GPIO_OUTPUT_SHIFT + offset),

				  val << (SN_GPIO_OUTPUT_SHIFT + offset));

	if (ret)

		dev_warn(pdata->dev,

			 "Failed to set bridge GPIO %u: %d\n", offset, ret);

}



static int ti_sn_bridge_gpio_direction_input(struct gpio_chip *chip,
@@ -1793,7 +1789,7 @@ static int ti_sn_gpio_probe(struct auxiliary_device *adev, 
	pdata->gchip.direction_input = ti_sn_bridge_gpio_direction_input;

	pdata->gchip.direction_output = ti_sn_bridge_gpio_direction_output;

	pdata->gchip.get = ti_sn_bridge_gpio_get;

	pdata->gchip.set = ti_sn_bridge_gpio_set;

	pdata->gchip.set_rv = ti_sn_bridge_gpio_set;

	pdata->gchip.can_sleep = true;

	pdata->gchip.names = ti_sn_bridge_gpio_names;

	pdata->gchip.ngpio = SN_NUM_GPIOS;