Commit 98f9e447 authored by Wolfram Sang's avatar Wolfram Sang Committed by Herbert Xu
Browse files

crypto: api - use 'time_left' variable with wait_for_completion_killable_timeout() 



There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_killable_timeout() causing patterns like:

	timeout = wait_for_completion_killable_timeout(...)
	if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent d2835701

crypto/api.c

+4 −4
Original line number Diff line number Diff line
@@ -202,18 +202,18 @@ static void crypto_start_test(struct crypto_larval *larval) 
static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg)

{

	struct crypto_larval *larval = (void *)alg;

	long timeout;

	long time_left;



	if (!crypto_boot_test_finished())

		crypto_start_test(larval);



	timeout = wait_for_completion_killable_timeout(

	time_left = wait_for_completion_killable_timeout(

		&larval->completion, 60 * HZ);



	alg = larval->adult;

	if (timeout < 0)

	if (time_left < 0)

		alg = ERR_PTR(-EINTR);

	else if (!timeout)

	else if (!time_left)

		alg = ERR_PTR(-ETIMEDOUT);

	else if (!alg)

		alg = ERR_PTR(-ENOENT);