Commit 99067b58 authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: mac80211: don't WARN for connections on invalid channels 



It's not clear (to me) how exactly syzbot managed to hit this,
but it seems conceivable that e.g. regulatory changed and has
disabled a channel between scanning (channel is checked to be
usable by cfg80211_get_ies_channel_number) and connecting on
the channel later.

With one scenario that isn't covered elsewhere described above,
the warning isn't good, replace it with a (more informative)
error message.

Reported-by: default avatar <syzbot+639af5aa411f2581ad38@syzkaller.appspotmail.com>
Link: https://patch.msgid.link/20251202102511.5a8fb5184fa3.I961ee41b8f10538a54b8565dbf03ec1696e80e03@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent e75665dd

net/mac80211/mlme.c

+4 −1
Original line number Diff line number Diff line
@@ -1126,7 +1126,10 @@ ieee80211_determine_chan_mode(struct ieee80211_sub_if_data *sdata, 


	while (!ieee80211_chandef_usable(sdata, &chanreq->oper,

					 IEEE80211_CHAN_DISABLED)) {

		if (WARN_ON(chanreq->oper.width == NL80211_CHAN_WIDTH_20_NOHT)) {

		if (chanreq->oper.width == NL80211_CHAN_WIDTH_20_NOHT) {

			link_id_info(sdata, link_id,

				     "unusable channel (%d MHz) for connection\n",

				     chanreq->oper.chan->center_freq);

			ret = -EINVAL;

			goto free;

		}