Commit 991a1b09 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski
Browse files

eth: fbnic: fix memory corruption in fbnic_tlv_attr_get_string() 



This code is trying to ensure that the last byte of the buffer is a NUL
terminator.  However, the problem is that attr->value[] is an array of
__le32, not char, so it zeroes out 4 bytes way beyond the end of the
buffer.  Cast the buffer to char to address this.

Fixes: e5cf5107 ("eth: fbnic: Update fbnic_tlv_attr_get_string() to work like nla_strscpy()")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarLee Trager <lee@trager.us>
Link: https://patch.msgid.link/2791d4be-ade4-4e50-9b12-33307d8410f6@stanley.mountain


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 473367a5

drivers/net/ethernet/meta/fbnic/fbnic_tlv.c

+1 −1
Original line number Diff line number Diff line
@@ -261,7 +261,7 @@ ssize_t fbnic_tlv_attr_get_string(struct fbnic_tlv_msg *attr, char *dst, 
		return -E2BIG;



	srclen = le16_to_cpu(attr->hdr.len) - sizeof(*attr);

	if (srclen > 0 && attr->value[srclen - 1] == '\0')

	if (srclen > 0 && ((char *)attr->value)[srclen - 1] == '\0')

		srclen--;



	if (srclen >= dstsize) {