Commit 9929ba19 authored by Breno Leitao's avatar Breno Leitao Committed by Jakub Kicinski
Browse files

net: Use nlmsg_payload in neighbour file 



Leverage the new nlmsg_payload() helper to avoid checking for message
size and then reading the nlmsg data.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250417-nlmsg_v3-v1-1-9b09d9d7e61d@debian.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 199561a4

net/core/neighbour.c

+2 −2
Original line number Diff line number Diff line
@@ -2747,12 +2747,12 @@ static int neigh_valid_dump_req(const struct nlmsghdr *nlh, 
	if (strict_check) {

		struct ndmsg *ndm;



		if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*ndm))) {

		ndm = nlmsg_payload(nlh, sizeof(*ndm));

		if (!ndm) {

			NL_SET_ERR_MSG(extack, "Invalid header for neighbor dump request");

			return -EINVAL;

		}



		ndm = nlmsg_data(nlh);

		if (ndm->ndm_pad1  || ndm->ndm_pad2  || ndm->ndm_ifindex ||

		    ndm->ndm_state || ndm->ndm_type) {

			NL_SET_ERR_MSG(extack, "Invalid values in header for neighbor dump request");