Commit 992e8833 authored by Viresh Kumar's avatar Viresh Kumar
Browse files

OPP: debugfs: Fix warning with W=1 builds 



We currently get the following warning:

debugfs.c:105:54: error: '%d' directive output may be truncated writing between 1 and 11 bytes into a region of size 8 [-Werror=format-truncation=]
                 snprintf(name, sizeof(name), "supply-%d", i);
                                                      ^~
debugfs.c:105:46: note: directive argument in the range [-2147483644, 2147483646]
                 snprintf(name, sizeof(name), "supply-%d", i);
                                              ^~~~~~~~~~~
debugfs.c:105:17: note: 'snprintf' output between 9 and 19 bytes into a destination of size 15
                 snprintf(name, sizeof(name), "supply-%d", i);

Fix this and other potential issues it by allocating larger arrays.
Use the exact string format to allocate the arrays without getting into
these issues again.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402141313.81ltVF5g-lkp@intel.com/


Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarDhruva Gole <d-gole@ti.com>
parent 838a4772

drivers/opp/debugfs.c

+4 −4
Original line number Diff line number Diff line
@@ -56,11 +56,11 @@ static void opp_debug_create_bw(struct dev_pm_opp *opp, 
				struct dentry *pdentry)

{

	struct dentry *d;

	char name[20];

	char name[] = "icc-path-XXXXXXXXXXX"; /* Integers can take 11 chars max */

	int i;



	for (i = 0; i < opp_table->path_count; i++) {

		snprintf(name, sizeof(name), "icc-path-%.1d", i);

		snprintf(name, sizeof(name), "icc-path-%d", i);



		/* Create per-path directory */

		d = debugfs_create_dir(name, pdentry);
@@ -78,7 +78,7 @@ static void opp_debug_create_clks(struct dev_pm_opp *opp, 
				  struct opp_table *opp_table,

				  struct dentry *pdentry)

{

	char name[12];

	char name[] = "rate_hz_XXXXXXXXXXX"; /* Integers can take 11 chars max */

	int i;



	if (opp_table->clk_count == 1) {
@@ -100,7 +100,7 @@ static void opp_debug_create_supplies(struct dev_pm_opp *opp, 
	int i;



	for (i = 0; i < opp_table->regulator_count; i++) {

		char name[15];

		char name[] = "supply-XXXXXXXXXXX"; /* Integers can take 11 chars max */



		snprintf(name, sizeof(name), "supply-%d", i);