Commit 99474727 authored by Kees Cook's avatar Kees Cook Committed by David S. Miller
Browse files

flow_offload: Annotate struct flow_action_entry with __counted_by 

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct flow_action_entry.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

 [1]
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Reviewed-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b3783e5e

include/net/flow_offload.h

+1 −1
Original line number Diff line number Diff line
@@ -333,7 +333,7 @@ struct flow_action_entry { 


struct flow_action {

	unsigned int			num_entries;

	struct flow_action_entry	entries[];

	struct flow_action_entry	entries[] __counted_by(num_entries);

};



static inline bool flow_action_has_entries(const struct flow_action *action)