Commit 99600f79 authored by Sabrina Dubroca's avatar Sabrina Dubroca Committed by Jakub Kicinski
Browse files

mpls: add missing unregister_netdevice_notifier to mpls_init 



If mpls_init() fails after registering mpls_dev_notifier, it never
gets removed. Add the missing unregister_netdevice_notifier() call to
the error handling path.

Fixes: 5be2062e ("mpls: Handle error of rtnl_register_module().")
Signed-off-by: default avatarSabrina Dubroca <sd@queasysnail.net>
Link: https://patch.msgid.link/7c55363c4f743d19e2306204a134407c90a69bbb.1773228081.git.sd@queasysnail.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8431c602

net/mpls/af_mpls.c

+1 −0
Original line number Diff line number Diff line
@@ -2854,6 +2854,7 @@ static int __init mpls_init(void) 
	rtnl_af_unregister(&mpls_af_ops);

out_unregister_dev_type:

	dev_remove_pack(&mpls_packet_type);

	unregister_netdevice_notifier(&mpls_dev_notifier);

out_unregister_pernet:

	unregister_pernet_subsys(&mpls_net_ops);

	goto out;