Commit 99767a0c authored by Waqar Hameed's avatar Waqar Hameed Committed by Lee Jones
Browse files

mfd: macsmc: Remove error prints for devm_add_action_or_reset() 



When `devm_add_action_or_reset()` fails, it is due to a failed memory
allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
anything when error is `-ENOMEM`. Therefore, remove the useless call to
`dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
return the value instead.

Signed-off-by: default avatarWaqar Hameed <waqar.hameed@axis.com>
Reviewed-by: default avatarSven Peter <sven@kernel.org>
Link: https://lore.kernel.org/r/pnd8qjym7td.a.out@axis.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 9ac4890a

drivers/mfd/macsmc.c

+2 −2
Original line number Diff line number Diff line
@@ -429,7 +429,7 @@ static int apple_smc_probe(struct platform_device *pdev) 


	ret = devm_add_action_or_reset(dev, apple_smc_rtkit_shutdown, smc);

	if (ret)

		return dev_err_probe(dev, ret, "Failed to register rtkit shutdown action");

		return ret;



	ret = apple_rtkit_start_ep(smc->rtk, SMC_ENDPOINT);

	if (ret)
@@ -465,7 +465,7 @@ static int apple_smc_probe(struct platform_device *pdev) 
	apple_smc_write_flag(smc, SMC_KEY(NTAP), true);

	ret = devm_add_action_or_reset(dev, apple_smc_disable_notifications, smc);

	if (ret)

		return dev_err_probe(dev, ret, "Failed to register notification disable action");

		return ret;



	ret = devm_mfd_add_devices(smc->dev, PLATFORM_DEVID_NONE,

				   apple_smc_devs, ARRAY_SIZE(apple_smc_devs),