Commit 9986ce65 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Niklas Cassel
Browse files

ata: Constify struct pci_device_id 



'struct pci_device_id' is not modified in these drivers.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig, as an example:
Before:
======
   text	   data	    bss	    dec	    hex	filename
   4245	   1454	      4	   5703	   1647	drivers/ata/ata_generic.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
   4725	    974	      4	   5703	   1647	drivers/ata/ata_generic.o

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/8bddfee7f6f0f90eeb6da7156e30ab3bd553deb1.1731704917.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarNiklas Cassel <cassel@kernel.org>
parent 40384c84

drivers/ata/ata_generic.c

+1 −1
Original line number Diff line number Diff line
@@ -209,7 +209,7 @@ static int ata_generic_init_one(struct pci_dev *dev, const struct pci_device_id 
	return ata_pci_bmdma_init_one(dev, ppi, &generic_sht, (void *)id, 0);

}



static struct pci_device_id ata_generic[] = {

static const struct pci_device_id ata_generic[] = {

	{ PCI_DEVICE(PCI_VENDOR_ID_PCTECH, PCI_DEVICE_ID_PCTECH_SAMURAI_IDE), },

	{ PCI_DEVICE(PCI_VENDOR_ID_HOLTEK, PCI_DEVICE_ID_HOLTEK_6565), },

	{ PCI_DEVICE(PCI_VENDOR_ID_UMC,    PCI_DEVICE_ID_UMC_UM8673F), },

drivers/ata/pata_atp867x.c

+1 −1
Original line number Diff line number Diff line
@@ -525,7 +525,7 @@ static int atp867x_reinit_one(struct pci_dev *pdev) 
}

#endif



static struct pci_device_id atp867x_pci_tbl[] = {

static const struct pci_device_id atp867x_pci_tbl[] = {

	{ PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP867A),	0 },

	{ PCI_VDEVICE(ARTOP, PCI_DEVICE_ID_ARTOP_ATP867B),	0 },

	{ },

drivers/ata/pata_piccolo.c

+1 −1
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ static int ata_tosh_init_one(struct pci_dev *dev, const struct pci_device_id *id 
	return ata_pci_bmdma_init_one(dev, ppi, &tosh_sht, NULL, 0);

}



static struct pci_device_id ata_tosh[] = {

static const struct pci_device_id ata_tosh[] = {

	{ PCI_DEVICE(PCI_VENDOR_ID_TOSHIBA,PCI_DEVICE_ID_TOSHIBA_PICCOLO_1), },

	{ PCI_DEVICE(PCI_VENDOR_ID_TOSHIBA,PCI_DEVICE_ID_TOSHIBA_PICCOLO_2),  },

	{ PCI_DEVICE(PCI_VENDOR_ID_TOSHIBA,PCI_DEVICE_ID_TOSHIBA_PICCOLO_3),  },