Unverified Commit 999fb9d5 authored by Luca Weiss's avatar Luca Weiss Committed by Mark Brown
Browse files

ASoC: qcom: sm8250: Fix possibly undefined reference 



With CONFIG_SND_SOC_SM8250=y and CONFIG_SND_SOC_QCOM_OFFLOAD_UTILS=m
selected in kconfig, the build will fail due to trying to link against a
symbol only found in the module.

  aarch64-linux-gnu-ld: sound/soc/qcom/sm8250.o: in function `sm8250_snd_exit':
  sound/soc/qcom/sm8250.c:52:(.text+0x210): undefined reference to `qcom_snd_usb_offload_jack_remove'

Fix this by declaring the dependency that forces CONFIG_SND_SOC_SM8250=m
when CONFIG_SND_SOC_QCOM_OFFLOAD_UTILS is =m.

Reported-by: default avatarMatthew Croughan <matthew.croughan@nix.how>
Fixes: 1b8d0d87 ("ASoC: qcom: qdsp6: Add headphone jack for offload connection status")
Signed-off-by: default avatarLuca Weiss <luca.weiss@fairphone.com>
Link: https://patch.msgid.link/20250617-snd-sm8250-dep-fix-v1-1-879af8906ec4@fairphone.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 86731a2a

sound/soc/qcom/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -186,6 +186,7 @@ config SND_SOC_SM8250 
	tristate "SoC Machine driver for SM8250 boards"

	depends on QCOM_APR && SOUNDWIRE

	depends on COMMON_CLK

	depends on SND_SOC_QCOM_OFFLOAD_UTILS || !SND_SOC_QCOM_OFFLOAD_UTILS

	select SND_SOC_QDSP6

	select SND_SOC_QCOM_COMMON

	select SND_SOC_QCOM_SDW