Commit 99b70ece authored by Suchit Karunakaran's avatar Suchit Karunakaran Committed by Andrew Morton
Browse files

checkpatch: suppress strscpy warnings for userspace tools 

The checkpatch.pl script currently warns against the use of strcpy,
strlcpy, and strncpy, recommending strscpy as a safer alternative. 
However, these warnings are also triggered for code under tools/ and
scripts/, which are userspace utilities where strscpy is not available. 
This patch suppresses these warnings for files in tools/ and scripts/.

Link: https://lkml.kernel.org/r/20250923171722.7798-1-suchitkarunakaran@gmail.com


Signed-off-by: default avatarSuchit Karunakaran <suchitkarunakaran@gmail.com>
Acked-by: default avatarJoe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 20a8e045

scripts/checkpatch.pl

+8 −4
Original line number Diff line number Diff line
@@ -2636,6 +2636,11 @@ sub exclude_global_initialisers { 
		$realfile =~ m@/bpf/.*\.bpf\.c$@;

}



sub is_userspace {

    my ($realfile) = @_;

    return ($realfile =~ m@^tools/@ || $realfile =~ m@^scripts/@);

}



sub process {

	my $filename = shift;
@@ -7018,21 +7023,20 @@ sub process { 
#				}

#			}

#		}



# strcpy uses that should likely be strscpy

		if ($line =~ /\bstrcpy\s*\(/) {

		if ($line =~ /\bstrcpy\s*\(/ && !is_userspace($realfile)) {

			WARN("STRCPY",

			     "Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88\n" . $herecurr);

		}



# strlcpy uses that should likely be strscpy

		if ($line =~ /\bstrlcpy\s*\(/) {

		if ($line =~ /\bstrlcpy\s*\(/ && !is_userspace($realfile)) {

			WARN("STRLCPY",

			     "Prefer strscpy over strlcpy - see: https://github.com/KSPP/linux/issues/89\n" . $herecurr);

		}



# strncpy uses that should likely be strscpy or strscpy_pad

		if ($line =~ /\bstrncpy\s*\(/) {

		if ($line =~ /\bstrncpy\s*\(/ && !is_userspace($realfile)) {

			WARN("STRNCPY",

			     "Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90\n" . $herecurr);

		}