Commit 99bf7c2e authored by Dan Carpenter's avatar Dan Carpenter Committed by Guenter Roeck
Browse files

hwmon: (ltc2991) re-order conditions to fix off by one bug 



LTC2991_T_INT_CH_NR is 4.  The st->temp_en[] array has LTC2991_MAX_CHANNEL
(4) elements.  Thus if "channel" is equal to LTC2991_T_INT_CH_NR then we
have read one element beyond the end of the array.  Flip the conditions
around so that we check if "channel" is valid before using it as an array
index.

Fixes: 2b9ea426 ("hwmon: Add driver for ltc2991")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/Zoa9Y_UMY4_ROfhF@stanley.mountain


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent cd228e7b

drivers/hwmon/ltc2991.c

+2 −2
Original line number Diff line number Diff line
@@ -225,8 +225,8 @@ static umode_t ltc2991_is_visible(const void *data, 
	case hwmon_temp:

		switch (attr) {

		case hwmon_temp_input:

			if (st->temp_en[channel] ||

			    channel == LTC2991_T_INT_CH_NR)

			if (channel == LTC2991_T_INT_CH_NR ||

			    st->temp_en[channel])

				return 0444;

			break;

		}