Commit 99f201a9 authored by Yedidya Benshimol's avatar Yedidya Benshimol Committed by Johannes Berg
Browse files

wifi: iwlwifi: mld: reduce scope for uninitialized variable 



After resuming from D3, keeping the connection or disconnecting
isn't relevant for the case of netdetect.
Reduce the scope of the keep_connection indicator to wowlan only.

Fixes: d1e879ec ("wifi: iwlwifi: add iwlmld sub-driver")
Signed-off-by: default avatarYedidya Benshimol <yedidya.ben.shimol@intel.com>
Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250401064530.769f76a9ad6e.I69e8f194997eb3a20e40d27fdc31002d5753d905@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 1a9239bb

drivers/net/wireless/intel/iwlwifi/mld/d3.c

+3 −5
Original line number Diff line number Diff line
@@ -1895,7 +1895,6 @@ int iwl_mld_wowlan_resume(struct iwl_mld *mld) 
	int link_id;

	int ret;

	bool fw_err = false;

	bool keep_connection;



	lockdep_assert_wiphy(mld->wiphy);
@@ -1965,7 +1964,7 @@ int iwl_mld_wowlan_resume(struct iwl_mld *mld) 
		iwl_mld_process_netdetect_res(mld, bss_vif, &resume_data);

		mld->netdetect = false;

	} else {

		keep_connection =

		bool keep_connection =

			iwl_mld_process_wowlan_status(mld, bss_vif,

						      resume_data.wowlan_status);
@@ -1973,10 +1972,9 @@ int iwl_mld_wowlan_resume(struct iwl_mld *mld) 
		if (keep_connection)

			iwl_mld_unblock_emlsr(mld, bss_vif,

					      IWL_MLD_EMLSR_BLOCKED_WOWLAN);

	}



	if (!mld->netdetect && !keep_connection)

		else

			ieee80211_resume_disconnect(bss_vif);

	}



	goto out;