Commit 99f98895 authored by Christian Marangi's avatar Christian Marangi Committed by Manivannan Sadhasivam
Browse files

dt-bindings: PCI: mediatek: Convert to YAML schema 



Convert the PCI mediatek Documentation to YAML schema to enable
validation of the supported GEN1/2 Mediatek PCIe controller.

While converting, lots of cleanup were done from the .txt with better
specifying what is supported by the various PCIe controller variant and
drop of redundant info that are part of the standard PCIe Host Bridge
schema.

To reduce schema complexity the .txt is split in 2 YAML, one for
mt7623/mt2701 and the other for every other compatible.

Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Signed-off-by: default avatarManivannan Sadhasivam <mani@kernel.org>
Reviewed-by: default avatarRob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20251020111121.31779-2-ansuelsmth@gmail.com
parent 3a866087

Documentation/devicetree/bindings/pci/mediatek-pcie-mt7623.yaml

0 → 100644
+164 −0
Original line number Diff line number Diff line 
# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

%YAML 1.2

---

$id: http://devicetree.org/schemas/pci/mediatek-pcie-mt7623.yaml#

$schema: http://devicetree.org/meta-schemas/core.yaml#



title: PCIe controller on MediaTek SoCs



maintainers:

  - Christian Marangi <ansuelsmth@gmail.com>



properties:

  compatible:

    enum:

      - mediatek,mt2701-pcie

      - mediatek,mt7623-pcie



  reg:

    minItems: 4

    maxItems: 4



  reg-names:

    items:

      - const: subsys

      - const: port0

      - const: port1

      - const: port2



  clocks:

    minItems: 4

    maxItems: 4



  clock-names:

    items:

      - const: free_ck

      - const: sys_ck0

      - const: sys_ck1

      - const: sys_ck2



  resets:

    minItems: 3

    maxItems: 3



  reset-names:

    items:

      - const: pcie-rst0

      - const: pcie-rst1

      - const: pcie-rst2



  phys:

    minItems: 3

    maxItems: 3



  phy-names:

    items:

      - const: pcie-phy0

      - const: pcie-phy1

      - const: pcie-phy2



  power-domains:

    maxItems: 1



required:

  - compatible

  - reg

  - reg-names

  - ranges

  - clocks

  - clock-names

  - '#interrupt-cells'

  - resets

  - reset-names

  - phys

  - phy-names

  - power-domains

  - pcie@0,0

  - pcie@1,0

  - pcie@2,0



allOf:

  - $ref: /schemas/pci/pci-host-bridge.yaml#



unevaluatedProperties: false



examples:

  # MT7623

  - |

    #include <dt-bindings/interrupt-controller/arm-gic.h>

    #include <dt-bindings/interrupt-controller/irq.h>

    #include <dt-bindings/clock/mt2701-clk.h>

    #include <dt-bindings/reset/mt2701-resets.h>

    #include <dt-bindings/phy/phy.h>

    #include <dt-bindings/power/mt2701-power.h>



    soc {

        #address-cells = <2>;

        #size-cells = <2>;



        pcie@1a140000 {

            compatible = "mediatek,mt7623-pcie";

            device_type = "pci";

            reg = <0 0x1a140000 0 0x1000>, /* PCIe shared registers */

                  <0 0x1a142000 0 0x1000>, /* Port0 registers */

                  <0 0x1a143000 0 0x1000>, /* Port1 registers */

                  <0 0x1a144000 0 0x1000>; /* Port2 registers */

            reg-names = "subsys", "port0", "port1", "port2";

            #address-cells = <3>;

            #size-cells = <2>;

            #interrupt-cells = <1>;

            interrupt-map-mask = <0xf800 0 0 0>;

            interrupt-map = <0x0000 0 0 0 &sysirq GIC_SPI 193 IRQ_TYPE_LEVEL_LOW>,

                            <0x0800 0 0 0 &sysirq GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>,

                            <0x1000 0 0 0 &sysirq GIC_SPI 195 IRQ_TYPE_LEVEL_LOW>;

            clocks = <&topckgen CLK_TOP_ETHIF_SEL>,

                    <&hifsys CLK_HIFSYS_PCIE0>,

                    <&hifsys CLK_HIFSYS_PCIE1>,

                    <&hifsys CLK_HIFSYS_PCIE2>;

            clock-names = "free_ck", "sys_ck0", "sys_ck1", "sys_ck2";

            resets = <&hifsys MT2701_HIFSYS_PCIE0_RST>,

                     <&hifsys MT2701_HIFSYS_PCIE1_RST>,

                     <&hifsys MT2701_HIFSYS_PCIE2_RST>;

            reset-names = "pcie-rst0", "pcie-rst1", "pcie-rst2";

            phys = <&pcie0_phy PHY_TYPE_PCIE>, <&pcie1_phy PHY_TYPE_PCIE>,

                   <&pcie2_phy PHY_TYPE_PCIE>;

            phy-names = "pcie-phy0", "pcie-phy1", "pcie-phy2";

            power-domains = <&scpsys MT2701_POWER_DOMAIN_HIF>;

            bus-range = <0x00 0xff>;

            ranges = <0x81000000 0 0x1a160000 0 0x1a160000 0 0x00010000>,	/* I/O space */

                     <0x83000000 0 0x60000000 0 0x60000000 0 0x10000000>;	/* memory space */



            pcie@0,0 {

                device_type = "pci";

                reg = <0x0000 0 0 0 0>;

                #address-cells = <3>;

                #size-cells = <2>;

                #interrupt-cells = <1>;

                interrupt-map-mask = <0 0 0 0>;

                interrupt-map = <0 0 0 0 &sysirq GIC_SPI 193 IRQ_TYPE_LEVEL_LOW>;

                ranges;

            };



            pcie@1,0 {

                device_type = "pci";

                reg = <0x0800 0 0 0 0>;

                #address-cells = <3>;

                #size-cells = <2>;

                #interrupt-cells = <1>;

                interrupt-map-mask = <0 0 0 0>;

                interrupt-map = <0 0 0 0 &sysirq GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>;

                ranges;

            };



            pcie@2,0 {

                device_type = "pci";

                reg = <0x1000 0 0 0 0>;

                #address-cells = <3>;

                #size-cells = <2>;

                #interrupt-cells = <1>;

                interrupt-map-mask = <0 0 0 0>;

                interrupt-map = <0 0 0 0 &sysirq GIC_SPI 195 IRQ_TYPE_LEVEL_LOW>;

                ranges;

            };

        };

    };

Documentation/devicetree/bindings/pci/mediatek-pcie.txt

deleted100644 → 0
+0 −289
Original line number Diff line number Diff line 
MediaTek Gen2 PCIe controller



Required properties:

- compatible: Should contain one of the following strings:

	"mediatek,mt2701-pcie"

	"mediatek,mt2712-pcie"

	"mediatek,mt7622-pcie"

	"mediatek,mt7623-pcie"

	"mediatek,mt7629-pcie"

	"airoha,en7523-pcie"

- device_type: Must be "pci"

- reg: Base addresses and lengths of the root ports.

- reg-names: Names of the above areas to use during resource lookup.

- #address-cells: Address representation for root ports (must be 3)

- #size-cells: Size representation for root ports (must be 2)

- clocks: Must contain an entry for each entry in clock-names.

  See ../clocks/clock-bindings.txt for details.

- clock-names:

  Mandatory entries:

   - sys_ckN :transaction layer and data link layer clock

  Required entries for MT2701/MT7623:

   - free_ck :for reference clock of PCIe subsys

  Required entries for MT2712/MT7622:

   - ahb_ckN :AHB slave interface operating clock for CSR access and RC

	      initiated MMIO access

  Required entries for MT7622:

   - axi_ckN :application layer MMIO channel operating clock

   - aux_ckN :pe2_mac_bridge and pe2_mac_core operating clock when

	      pcie_mac_ck/pcie_pipe_ck is turned off

   - obff_ckN :OBFF functional block operating clock

   - pipe_ckN :LTSSM and PHY/MAC layer operating clock

  where N starting from 0 to one less than the number of root ports.

- phys: List of PHY specifiers (used by generic PHY framework).

- phy-names : Must be "pcie-phy0", "pcie-phy1", "pcie-phyN".. based on the

  number of PHYs as specified in *phys* property.

- power-domains: A phandle and power domain specifier pair to the power domain

  which is responsible for collapsing and restoring power to the peripheral.

- bus-range: Range of bus numbers associated with this controller.

- ranges: Ranges for the PCI memory and I/O regions.



Required properties for MT7623/MT2701:

- #interrupt-cells: Size representation for interrupts (must be 1)

- interrupt-map-mask and interrupt-map: Standard PCI IRQ mapping properties

  Please refer to the standard PCI bus binding document for a more detailed

  explanation.

- resets: Must contain an entry for each entry in reset-names.

  See ../reset/reset.txt for details.

- reset-names: Must be "pcie-rst0", "pcie-rst1", "pcie-rstN".. based on the

  number of root ports.



Required properties for MT2712/MT7622/MT7629:

-interrupts: A list of interrupt outputs of the controller, must have one

	     entry for each PCIe port

- interrupt-names: Must include the following entries:

	- "pcie_irq": The interrupt that is asserted when an MSI/INTX is received

- linux,pci-domain: PCI domain ID. Should be unique for each host controller



In addition, the device tree node must have sub-nodes describing each

PCIe port interface, having the following mandatory properties:



Required properties:

- device_type: Must be "pci"

- reg: Only the first four bytes are used to refer to the correct bus number

  and device number.

- #address-cells: Must be 3

- #size-cells: Must be 2

- #interrupt-cells: Must be 1

- interrupt-map-mask and interrupt-map: Standard PCI IRQ mapping properties

  Please refer to the standard PCI bus binding document for a more detailed

  explanation.

- ranges: Sub-ranges distributed from the PCIe controller node. An empty

  property is sufficient.



Examples for MT7623:



	hifsys: syscon@1a000000 {

		compatible = "mediatek,mt7623-hifsys",

			     "mediatek,mt2701-hifsys",

			     "syscon";

		reg = <0 0x1a000000 0 0x1000>;

		#clock-cells = <1>;

		#reset-cells = <1>;

	};



	pcie: pcie@1a140000 {

		compatible = "mediatek,mt7623-pcie";

		device_type = "pci";

		reg = <0 0x1a140000 0 0x1000>, /* PCIe shared registers */

		      <0 0x1a142000 0 0x1000>, /* Port0 registers */

		      <0 0x1a143000 0 0x1000>, /* Port1 registers */

		      <0 0x1a144000 0 0x1000>; /* Port2 registers */

		reg-names = "subsys", "port0", "port1", "port2";

		#address-cells = <3>;

		#size-cells = <2>;

		#interrupt-cells = <1>;

		interrupt-map-mask = <0xf800 0 0 0>;

		interrupt-map = <0x0000 0 0 0 &sysirq GIC_SPI 193 IRQ_TYPE_LEVEL_LOW>,

				<0x0800 0 0 0 &sysirq GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>,

				<0x1000 0 0 0 &sysirq GIC_SPI 195 IRQ_TYPE_LEVEL_LOW>;

		clocks = <&topckgen CLK_TOP_ETHIF_SEL>,

			 <&hifsys CLK_HIFSYS_PCIE0>,

			 <&hifsys CLK_HIFSYS_PCIE1>,

			 <&hifsys CLK_HIFSYS_PCIE2>;

		clock-names = "free_ck", "sys_ck0", "sys_ck1", "sys_ck2";

		resets = <&hifsys MT2701_HIFSYS_PCIE0_RST>,

			 <&hifsys MT2701_HIFSYS_PCIE1_RST>,

			 <&hifsys MT2701_HIFSYS_PCIE2_RST>;

		reset-names = "pcie-rst0", "pcie-rst1", "pcie-rst2";

		phys = <&pcie0_phy PHY_TYPE_PCIE>, <&pcie1_phy PHY_TYPE_PCIE>,

		       <&pcie2_phy PHY_TYPE_PCIE>;

		phy-names = "pcie-phy0", "pcie-phy1", "pcie-phy2";

		power-domains = <&scpsys MT2701_POWER_DOMAIN_HIF>;

		bus-range = <0x00 0xff>;

		ranges = <0x81000000 0 0x1a160000 0 0x1a160000 0 0x00010000	/* I/O space */

			  0x83000000 0 0x60000000 0 0x60000000 0 0x10000000>;	/* memory space */



		pcie@0,0 {

			reg = <0x0000 0 0 0 0>;

			#address-cells = <3>;

			#size-cells = <2>;

			#interrupt-cells = <1>;

			interrupt-map-mask = <0 0 0 0>;

			interrupt-map = <0 0 0 0 &sysirq GIC_SPI 193 IRQ_TYPE_LEVEL_LOW>;

			ranges;

		};



		pcie@1,0 {

			reg = <0x0800 0 0 0 0>;

			#address-cells = <3>;

			#size-cells = <2>;

			#interrupt-cells = <1>;

			interrupt-map-mask = <0 0 0 0>;

			interrupt-map = <0 0 0 0 &sysirq GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>;

			ranges;

		};



		pcie@2,0 {

			reg = <0x1000 0 0 0 0>;

			#address-cells = <3>;

			#size-cells = <2>;

			#interrupt-cells = <1>;

			interrupt-map-mask = <0 0 0 0>;

			interrupt-map = <0 0 0 0 &sysirq GIC_SPI 195 IRQ_TYPE_LEVEL_LOW>;

			ranges;

		};

	};



Examples for MT2712:



	pcie1: pcie@112ff000 {

		compatible = "mediatek,mt2712-pcie";

		device_type = "pci";

		reg = <0 0x112ff000 0 0x1000>;

		reg-names = "port1";

		linux,pci-domain = <1>;

		#address-cells = <3>;

		#size-cells = <2>;

		interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;

		interrupt-names = "pcie_irq";

		clocks = <&topckgen CLK_TOP_PE2_MAC_P1_SEL>,

			 <&pericfg CLK_PERI_PCIE1>;

		clock-names = "sys_ck1", "ahb_ck1";

		phys = <&u3port1 PHY_TYPE_PCIE>;

		phy-names = "pcie-phy1";

		bus-range = <0x00 0xff>;

		ranges = <0x82000000 0 0x11400000  0x0 0x11400000  0 0x300000>;

		status = "disabled";



		#interrupt-cells = <1>;

		interrupt-map-mask = <0 0 0 7>;

		interrupt-map = <0 0 0 1 &pcie_intc1 0>,

				<0 0 0 2 &pcie_intc1 1>,

				<0 0 0 3 &pcie_intc1 2>,

				<0 0 0 4 &pcie_intc1 3>;

		pcie_intc1: interrupt-controller {

			interrupt-controller;

			#address-cells = <0>;

			#interrupt-cells = <1>;

		};

	};



	pcie0: pcie@11700000 {

		compatible = "mediatek,mt2712-pcie";

		device_type = "pci";

		reg = <0 0x11700000 0 0x1000>;

		reg-names = "port0";

		linux,pci-domain = <0>;

		#address-cells = <3>;

		#size-cells = <2>;

		interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;

		interrupt-names = "pcie_irq";

		clocks = <&topckgen CLK_TOP_PE2_MAC_P0_SEL>,

			 <&pericfg CLK_PERI_PCIE0>;

		clock-names = "sys_ck0", "ahb_ck0";

		phys = <&u3port0 PHY_TYPE_PCIE>;

		phy-names = "pcie-phy0";

		bus-range = <0x00 0xff>;

		ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>;

		status = "disabled";



		#interrupt-cells = <1>;

		interrupt-map-mask = <0 0 0 7>;

		interrupt-map = <0 0 0 1 &pcie_intc0 0>,

				<0 0 0 2 &pcie_intc0 1>,

				<0 0 0 3 &pcie_intc0 2>,

				<0 0 0 4 &pcie_intc0 3>;

		pcie_intc0: interrupt-controller {

			interrupt-controller;

			#address-cells = <0>;

			#interrupt-cells = <1>;

		};

	};



Examples for MT7622:



	pcie0: pcie@1a143000 {

		compatible = "mediatek,mt7622-pcie";

		device_type = "pci";

		reg = <0 0x1a143000 0 0x1000>;

		reg-names = "port0";

		linux,pci-domain = <0>;

		#address-cells = <3>;

		#size-cells = <2>;

		interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_LOW>;

		interrupt-names = "pcie_irq";

		clocks = <&pciesys CLK_PCIE_P0_MAC_EN>,

			 <&pciesys CLK_PCIE_P0_AHB_EN>,

			 <&pciesys CLK_PCIE_P0_AUX_EN>,

			 <&pciesys CLK_PCIE_P0_AXI_EN>,

			 <&pciesys CLK_PCIE_P0_OBFF_EN>,

			 <&pciesys CLK_PCIE_P0_PIPE_EN>;

		clock-names = "sys_ck0", "ahb_ck0", "aux_ck0",

			      "axi_ck0", "obff_ck0", "pipe_ck0";



		power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>;

		bus-range = <0x00 0xff>;

		ranges = <0x82000000 0 0x20000000  0x0 0x20000000  0 0x8000000>;

		status = "disabled";



		#interrupt-cells = <1>;

		interrupt-map-mask = <0 0 0 7>;

		interrupt-map = <0 0 0 1 &pcie_intc0 0>,

				<0 0 0 2 &pcie_intc0 1>,

				<0 0 0 3 &pcie_intc0 2>,

				<0 0 0 4 &pcie_intc0 3>;

		pcie_intc0: interrupt-controller {

			interrupt-controller;

			#address-cells = <0>;

			#interrupt-cells = <1>;

		};

	};



	pcie1: pcie@1a145000 {

		compatible = "mediatek,mt7622-pcie";

		device_type = "pci";

		reg = <0 0x1a145000 0 0x1000>;

		reg-names = "port1";

		linux,pci-domain = <1>;

		#address-cells = <3>;

		#size-cells = <2>;

		interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_LOW>;

		interrupt-names = "pcie_irq";

		clocks = <&pciesys CLK_PCIE_P1_MAC_EN>,

			 /* designer has connect RC1 with p0_ahb clock */

			 <&pciesys CLK_PCIE_P0_AHB_EN>,

			 <&pciesys CLK_PCIE_P1_AUX_EN>,

			 <&pciesys CLK_PCIE_P1_AXI_EN>,

			 <&pciesys CLK_PCIE_P1_OBFF_EN>,

			 <&pciesys CLK_PCIE_P1_PIPE_EN>;

		clock-names = "sys_ck1", "ahb_ck1", "aux_ck1",

			      "axi_ck1", "obff_ck1", "pipe_ck1";



		power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>;

		bus-range = <0x00 0xff>;

		ranges = <0x82000000 0 0x28000000  0x0 0x28000000  0 0x8000000>;

		status = "disabled";



		#interrupt-cells = <1>;

		interrupt-map-mask = <0 0 0 7>;

		interrupt-map = <0 0 0 1 &pcie_intc1 0>,

				<0 0 0 2 &pcie_intc1 1>,

				<0 0 0 3 &pcie_intc1 2>,

				<0 0 0 4 &pcie_intc1 3>;

		pcie_intc1: interrupt-controller {

			interrupt-controller;

			#address-cells = <0>;

			#interrupt-cells = <1>;

		};

	};

Documentation/devicetree/bindings/pci/mediatek-pcie.yaml

0 → 100644
+318 −0
Original line number Diff line number Diff line 
# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

%YAML 1.2

---

$id: http://devicetree.org/schemas/pci/mediatek-pcie.yaml#

$schema: http://devicetree.org/meta-schemas/core.yaml#



title: PCIe controller on MediaTek SoCs



maintainers:

  - Christian Marangi <ansuelsmth@gmail.com>



properties:

  compatible:

    oneOf:

      - enum:

          - mediatek,mt2712-pcie

          - mediatek,mt7622-pcie

          - mediatek,mt7629-pcie

      - items:

          - const: airoha,en7523-pcie

          - const: mediatek,mt7622-pcie



  reg:

    maxItems: 1



  reg-names:

    enum: [ port0, port1 ]



  clocks:

    minItems: 1

    maxItems: 6



  clock-names:

    minItems: 1

    items:

      - enum: [ sys_ck0, sys_ck1 ]

      - enum: [ ahb_ck0, ahb_ck1 ]

      - enum: [ aux_ck0, aux_ck1 ]

      - enum: [ axi_ck0, axi_ck1 ]

      - enum: [ obff_ck0, obff_ck1 ]

      - enum: [ pipe_ck0, pipe_ck1 ]



  interrupts:

    maxItems: 1



  interrupt-names:

    const: pcie_irq



  phys:

    maxItems: 1



  phy-names:

    enum: [ pcie-phy0, pcie-phy1 ]



  power-domains:

    maxItems: 1



  '#interrupt-cells':

    const: 1



  interrupt-controller:

    description: Interrupt controller node for handling legacy PCI interrupts.

    type: object

    properties:

      '#address-cells':

        const: 0

      '#interrupt-cells':

        const: 1

      interrupt-controller: true



    required:

      - '#address-cells'

      - '#interrupt-cells'

      - interrupt-controller



    additionalProperties: false



required:

  - compatible

  - reg

  - reg-names

  - ranges

  - clocks

  - clock-names

  - '#interrupt-cells'

  - interrupts

  - interrupt-names

  - interrupt-controller



allOf:

  - $ref: /schemas/pci/pci-host-bridge.yaml#



  - if:

      properties:

        compatible:

          const: mediatek,mt2712-pcie

    then:

      properties:

        clocks:

          minItems: 2

          maxItems: 2



        clock-names:

          minItems: 2

          maxItems: 2



        power-domains: false



      required:

        - phys

        - phy-names



  - if:

      properties:

        compatible:

          const: mediatek,mt7622-pcie

    then:

      properties:

        clocks:

          minItems: 6



        phys: false



        phy-names: false



      required:

        - power-domains



  - if:

      properties:

        compatible:

          const: mediatek,mt7629-pcie

    then:

      properties:

        clocks:

          minItems: 6



      required:

        - power-domains



  - if:

      properties:

        compatible:

          contains:

            const: airoha,en7523-pcie

    then:

      properties:

        clocks:

          maxItems: 1



        clock-names:

          maxItems: 1



        phys: false



        phy-names: false



        power-domain: false



unevaluatedProperties: false



examples:

  # MT2712

  - |

    #include <dt-bindings/interrupt-controller/arm-gic.h>

    #include <dt-bindings/interrupt-controller/irq.h>

    #include <dt-bindings/phy/phy.h>



    soc_1 {

        #address-cells = <2>;

        #size-cells = <2>;



        pcie@112ff000 {

            compatible = "mediatek,mt2712-pcie";

            device_type = "pci";

            reg = <0 0x112ff000 0 0x1000>;

            reg-names = "port1";

            linux,pci-domain = <1>;

            #address-cells = <3>;

            #size-cells = <2>;

            interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;

            interrupt-names = "pcie_irq";

            clocks = <&topckgen>, /* CLK_TOP_PE2_MAC_P1_SEL */

                     <&pericfg>; /* CLK_PERI_PCIE1 */

            clock-names = "sys_ck1", "ahb_ck1";

            phys = <&u3port1 PHY_TYPE_PCIE>;

            phy-names = "pcie-phy1";

            bus-range = <0x00 0xff>;

            ranges = <0x82000000 0 0x11400000  0x0 0x11400000  0 0x300000>;



            #interrupt-cells = <1>;

            interrupt-map-mask = <0 0 0 7>;

            interrupt-map = <0 0 0 1 &pcie_intc1 0>,

                            <0 0 0 2 &pcie_intc1 1>,

                            <0 0 0 3 &pcie_intc1 2>,

                            <0 0 0 4 &pcie_intc1 3>;

            pcie_intc1: interrupt-controller {

                interrupt-controller;

                #address-cells = <0>;

                #interrupt-cells = <1>;

            };

        };



        pcie@11700000 {

            compatible = "mediatek,mt2712-pcie";

            device_type = "pci";

            reg = <0 0x11700000 0 0x1000>;

            reg-names = "port0";

            linux,pci-domain = <0>;

            #address-cells = <3>;

            #size-cells = <2>;

            interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;

            interrupt-names = "pcie_irq";

            clocks = <&topckgen>, /* CLK_TOP_PE2_MAC_P0_SEL */

                     <&pericfg>; /* CLK_PERI_PCIE0 */

            clock-names = "sys_ck0", "ahb_ck0";

            phys = <&u3port0 PHY_TYPE_PCIE>;

            phy-names = "pcie-phy0";

            bus-range = <0x00 0xff>;

            ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>;



            #interrupt-cells = <1>;

            interrupt-map-mask = <0 0 0 7>;

            interrupt-map = <0 0 0 1 &pcie_intc0 0>,

                            <0 0 0 2 &pcie_intc0 1>,

                            <0 0 0 3 &pcie_intc0 2>,

                            <0 0 0 4 &pcie_intc0 3>;

            pcie_intc0: interrupt-controller {

                interrupt-controller;

                #address-cells = <0>;

                #interrupt-cells = <1>;

            };

        };

    };



  # MT7622

  - |

    #include <dt-bindings/interrupt-controller/arm-gic.h>

    #include <dt-bindings/interrupt-controller/irq.h>

    #include <dt-bindings/power/mt7622-power.h>



    soc_2 {

        #address-cells = <2>;

        #size-cells = <2>;



        pcie@1a143000 {

            compatible = "mediatek,mt7622-pcie";

            device_type = "pci";

            reg = <0 0x1a143000 0 0x1000>;

            reg-names = "port0";

            linux,pci-domain = <0>;

            #address-cells = <3>;

            #size-cells = <2>;

            interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_LOW>;

            interrupt-names = "pcie_irq";

            clocks = <&pciesys>, /* CLK_PCIE_P0_MAC_EN */

                     <&pciesys>, /* CLK_PCIE_P0_AHB_EN */

                     <&pciesys>, /* CLK_PCIE_P0_AUX_EN */

                     <&pciesys>, /* CLK_PCIE_P0_AXI_EN */

                     <&pciesys>, /* CLK_PCIE_P0_OBFF_EN */

                     <&pciesys>; /* CLK_PCIE_P0_PIPE_EN */

            clock-names = "sys_ck0", "ahb_ck0", "aux_ck0",

                          "axi_ck0", "obff_ck0", "pipe_ck0";



            power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>;

            bus-range = <0x00 0xff>;

            ranges = <0x82000000 0 0x20000000  0x0 0x20000000  0 0x8000000>;



            #interrupt-cells = <1>;

            interrupt-map-mask = <0 0 0 7>;

            interrupt-map = <0 0 0 1 &pcie_intc0_1 0>,

                            <0 0 0 2 &pcie_intc0_1 1>,

                            <0 0 0 3 &pcie_intc0_1 2>,

                            <0 0 0 4 &pcie_intc0_1 3>;

            pcie_intc0_1: interrupt-controller {

                interrupt-controller;

                #address-cells = <0>;

                #interrupt-cells = <1>;

            };

        };



        pcie@1a145000 {

            compatible = "mediatek,mt7622-pcie";

            device_type = "pci";

            reg = <0 0x1a145000 0 0x1000>;

            reg-names = "port1";

            linux,pci-domain = <1>;

            #address-cells = <3>;

            #size-cells = <2>;

            interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_LOW>;

            interrupt-names = "pcie_irq";

            clocks = <&pciesys>, /* CLK_PCIE_P1_MAC_EN */

                     /* designer has connect RC1 with p0_ahb clock */

                     <&pciesys>, /* CLK_PCIE_P0_AHB_EN */

                     <&pciesys>, /* CLK_PCIE_P1_AUX_EN */

                     <&pciesys>, /* CLK_PCIE_P1_AXI_EN */

                     <&pciesys>, /* CLK_PCIE_P1_OBFF_EN */

                     <&pciesys>; /* CLK_PCIE_P1_PIPE_EN */

            clock-names = "sys_ck1", "ahb_ck1", "aux_ck1",

                          "axi_ck1", "obff_ck1", "pipe_ck1";



            power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>;

            bus-range = <0x00 0xff>;

            ranges = <0x82000000 0 0x28000000  0x0 0x28000000  0 0x8000000>;



            #interrupt-cells = <1>;

            interrupt-map-mask = <0 0 0 7>;

            interrupt-map = <0 0 0 1 &pcie_intc1_1 0>,

                            <0 0 0 2 &pcie_intc1_1 1>,

                            <0 0 0 3 &pcie_intc1_1 2>,

                            <0 0 0 4 &pcie_intc1_1 3>;

            pcie_intc1_1: interrupt-controller {

                interrupt-controller;

                #address-cells = <0>;

                #interrupt-cells = <1>;

            };

        };

    };