Commit 99fea943 authored by Ricardo B. Marliere's avatar Ricardo B. Marliere Committed by Vinod Koul
Browse files

soundwire: constify the struct device_type usage 



Since commit aed65af1 ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the
sdw_master_type and sdw_slave_type variables to be constant structures as
well, placing it into read-only memory which can not be modified at
runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatar"Ricardo B. Marliere" <ricardo@marliere.net>
Link: https://lore.kernel.org/r/20240219-device_cleanup-soundwire-v1-1-9edd51767611@marliere.net


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 81a7d0c4

drivers/soundwire/master.c

+1 −1
Original line number Diff line number Diff line
@@ -112,7 +112,7 @@ static const struct dev_pm_ops master_dev_pm = { 
			   pm_generic_runtime_resume, NULL)

};



struct device_type sdw_master_type = {

const struct device_type sdw_master_type = {

	.name =		"soundwire_master",

	.release =	sdw_master_device_release,

	.pm = &master_dev_pm,

drivers/soundwire/slave.c

+1 −1
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ static void sdw_slave_release(struct device *dev) 
	kfree(slave);

}



struct device_type sdw_slave_type = {

const struct device_type sdw_slave_type = {

	.name =		"sdw_slave",

	.release =	sdw_slave_release,

	.uevent =	sdw_slave_uevent,

include/linux/soundwire/sdw_type.h

+2 −2
Original line number Diff line number Diff line
@@ -5,8 +5,8 @@ 
#define __SOUNDWIRE_TYPES_H



extern const struct bus_type sdw_bus_type;

extern struct device_type sdw_slave_type;

extern struct device_type sdw_master_type;

extern const struct device_type sdw_slave_type;

extern const struct device_type sdw_master_type;



static inline int is_sdw_slave(const struct device *dev)

{