Commit 9a046c1d authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Dmitry Torokhov
Browse files

Input: stmpe-ts - use module alias instead of device table 

When compile tested with W=1 on x86_64 with driver as built-in:

  stmpe-ts.c:371:34: error: unused variable 'stmpe_ts_ids' [-Werror,-Wunused-const-variable]

Ideally this would be referenced from the platform_driver, but since
the compatible string is already matched by the mfd driver for its
parent device, that would break probing.

In this case, the of_device_id table just serves as a module alias
for loading the driver, while the device itself is probed using
the platform device name.

Remove the table and instead use a module alias that reflects how
the driver is actually probed.

Link: https://lore.kernel.org/lkml/20240403080702.3509288-8-arnd@kernel.org/
Link: https://lore.kernel.org/lkml/181dbdb8-c050-4966-8cb4-2f39495ff3f9@app.fastmail.com/


Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20250409122314.2848028-3-arnd@kernel.org


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent c6cb8bf7

drivers/input/touchscreen/stmpe-ts.c

+1 −6
Original line number Diff line number Diff line
@@ -366,12 +366,7 @@ static struct platform_driver stmpe_ts_driver = { 
};

module_platform_driver(stmpe_ts_driver);



static const struct of_device_id stmpe_ts_ids[] = {

	{ .compatible = "st,stmpe-ts", },

	{ },

};

MODULE_DEVICE_TABLE(of, stmpe_ts_ids);



MODULE_ALIAS("platform:stmpe-ts");

MODULE_AUTHOR("Luotao Fu <l.fu@pengutronix.de>");

MODULE_DESCRIPTION("STMPEXXX touchscreen driver");

MODULE_LICENSE("GPL");