Commit 9a52827a authored by Johan Hovold's avatar Johan Hovold Committed by Philipp Zabel
Browse files

reset: eyeq: fix OF node leak 



Make sure to drop the OF node reference taken when probing the auxiliary
device when the device is later unbound.

Fixes: 487b1b32 ("reset: eyeq: add platform driver")
Cc: Théo Lebrun <theo.lebrun@bootlin.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/20250708085613.15823-1-johan@kernel.org


Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent 8f5ae30d

drivers/reset/reset-eyeq.c

+11 −0
Original line number Diff line number Diff line
@@ -410,6 +410,13 @@ static int eqr_of_xlate_twocells(struct reset_controller_dev *rcdev, 
	return eqr_of_xlate_internal(rcdev, reset_spec->args[0], reset_spec->args[1]);

}



static void eqr_of_node_put(void *_dev)

{

	struct device *dev = _dev;



	of_node_put(dev->of_node);

}



static int eqr_probe(struct auxiliary_device *adev,

		     const struct auxiliary_device_id *id)

{
@@ -428,6 +435,10 @@ static int eqr_probe(struct auxiliary_device *adev, 
	if (!dev->of_node)

		return -ENODEV;



	ret = devm_add_action_or_reset(dev, eqr_of_node_put, dev);

	if (ret)

		return ret;



	/*

	 * Using our newfound OF node, we can get match data. We cannot use

	 * device_get_match_data() because it does not match reused OF nodes.