Commit 9a74bfdf authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpufreq: Use locking guard and __free() in cpufreq_update_policy() 



Instead of using cpufreq_cpu_acquire() and cpufreq_cpu_release() in
cpufreq_update_policy(), which is the last user of these functions,
make it use __free() for policy reference counting cleanup and the
"write" locking guard for policy locking.

No intentional functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Acked-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Tested-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Link: https://patch.msgid.link/22654186.EfDdHjke4D@rjwysocki.net
parent 973207ae

drivers/cpufreq/cpufreq.c

+5 −5
Original line number Diff line number Diff line
@@ -2780,23 +2780,23 @@ static int cpufreq_set_policy(struct cpufreq_policy *policy, 
 */

void cpufreq_update_policy(unsigned int cpu)

{

	struct cpufreq_policy *policy = cpufreq_cpu_acquire(cpu);

	struct cpufreq_policy *policy __free(put_cpufreq_policy);



	policy = cpufreq_cpu_get(cpu);

	if (!policy)

		return;



	guard(cpufreq_policy_write)(policy);



	/*

	 * BIOS might change freq behind our back

	 * -> ask driver for current freq and notify governors about a change

	 */

	if (cpufreq_driver->get && has_target() &&

	    (cpufreq_suspended || WARN_ON(!cpufreq_verify_current_freq(policy, false))))

		goto unlock;

		return;



	refresh_frequency_limits(policy);



unlock:

	cpufreq_cpu_release(policy);

}

EXPORT_SYMBOL(cpufreq_update_policy);