Commit 9a884bdb authored by Stephen Rothwell's avatar Stephen Rothwell Committed by Peter Zijlstra
Browse files

iio: magnetometer: fix if () scoped_guard() formatting 

Add mising braces after an if condition that contains scoped_guard().

This style is both preferred and necessary here, to fix warning after
scoped_guard() change in commit fcc22ac5 ("cleanup: Adjust
scoped_guard() macros to avoid potential warning") to have if-else inside
of the macro. Current (no braces) use in af8133j_set_scale() yields
the following warnings:
af8133j.c:315:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
af8133j.c:316:3: warning: add explicit braces to avoid dangling else [-Wdangling-else]

Fixes: fcc22ac5 ("cleanup: Adjust scoped_guard() macros to avoid potential warning")
Closes: https://lore.kernel.org/oe-kbuild-all/202409270848.tTpyEAR7-lkp@intel.com/


Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20241108154258.21411-1-przemyslaw.kitszel@intel.com
parent 5c2e7736

drivers/iio/magnetometer/af8133j.c

+2 −1
Original line number Diff line number Diff line
@@ -312,10 +312,11 @@ static int af8133j_set_scale(struct af8133j_data *data, 
	 * When suspended, just store the new range to data->range to be

	 * applied later during power up.

	 */

	if (!pm_runtime_status_suspended(dev))

	if (!pm_runtime_status_suspended(dev)) {

		scoped_guard(mutex, &data->mutex)

			ret = regmap_write(data->regmap,

					   AF8133J_REG_RANGE, range);

	}



	pm_runtime_enable(dev);