Commit 9a945801 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: amdpt: remove remove() 



Use the managed variant of gpiochip_add_data() and remove the remove()
callback.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20241014092909.90607-1-brgl@bgdev.pl


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 3dcf0643

drivers/gpio/gpio-amdpt.c

+1 −9
Original line number Diff line number Diff line
@@ -106,7 +106,7 @@ static int pt_gpio_probe(struct platform_device *pdev) 
	pt_gpio->gc.free             = pt_gpio_free;

	pt_gpio->gc.ngpio            = (uintptr_t)device_get_match_data(dev);



	ret = gpiochip_add_data(&pt_gpio->gc, pt_gpio);

	ret = devm_gpiochip_add_data(dev, &pt_gpio->gc, pt_gpio);

	if (ret) {

		dev_err(dev, "Failed to register GPIO lib\n");

		return ret;
@@ -122,13 +122,6 @@ static int pt_gpio_probe(struct platform_device *pdev) 
	return ret;

}



static void pt_gpio_remove(struct platform_device *pdev)

{

	struct pt_gpio_chip *pt_gpio = platform_get_drvdata(pdev);



	gpiochip_remove(&pt_gpio->gc);

}



static const struct acpi_device_id pt_gpio_acpi_match[] = {

	{ "AMDF030", PT_TOTAL_GPIO },

	{ "AMDIF030", PT_TOTAL_GPIO },
@@ -143,7 +136,6 @@ static struct platform_driver pt_gpio_driver = { 
		.acpi_match_table = ACPI_PTR(pt_gpio_acpi_match),

	},

	.probe = pt_gpio_probe,

	.remove_new = pt_gpio_remove,

};



module_platform_driver(pt_gpio_driver);