Commit 9ac3ebae authored by Erick Archer's avatar Erick Archer Committed by Viresh Kumar
Browse files

Documentation: power: Use kcalloc() instead of kzalloc()



As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, in the example code use the purpose specific kcalloc() function
instead of the argument size * count in the kzalloc() function.

At the same time, modify the translations accordingly.

Signed-off-by: default avatarErick Archer <erick.archer@gmx.com>
Reviewed-by: default avatarHu Haowen <2023002089@link.tyut.edu.cn>
Reviewed-by: default avatarYanteng Si <siyanteng@loongson.cn>
Reviewed-by: default avatarHu Haowen <2023002089@link.tyut.edu.cn>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 788715b5
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -305,7 +305,7 @@ dev_pm_opp_get_opp_count
	 {
		/* Do things */
		num_available = dev_pm_opp_get_opp_count(dev);
		speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL);
		speeds = kcalloc(num_available, sizeof(u32), GFP_KERNEL);
		/* populate the table in increasing order */
		freq = 0;
		while (!IS_ERR(opp = dev_pm_opp_find_freq_ceil(dev, &freq))) {
+1 −1
Original line number Diff line number Diff line
@@ -274,7 +274,7 @@ dev_pm_opp_get_opp_count
	 {
		/* 做一些事情 */
		num_available = dev_pm_opp_get_opp_count(dev);
		speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL);
		speeds = kcalloc(num_available, sizeof(u32), GFP_KERNEL);
		/* 按升序填充表 */
		freq = 0;
		while (!IS_ERR(opp = dev_pm_opp_find_freq_ceil(dev, &freq))) {