Commit 9ac98662 authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Namhyung Kim
Browse files

perf: event: Remove deadcode 



event_format__print() last use was removed by 2017's
commit 894f3f17 ("perf script: Use event_format__fprintf()")

evlist__find_tracepoint_by_id() last use was removed by 2012's
commit e60fc847 ("perf evlist: Remove some unused methods")

evlist__set_tp_filter_pid() last use was removed by 2017's
commit dd1a5037 ("perf trace: Introduce filter_loop_pids()")

Remove them.

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: default avatarIan Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20241106144826.91728-1-linux@treblig.org


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent 5fb8e565

tools/perf/util/evlist.c

+0 −18
Original line number Diff line number Diff line
@@ -320,19 +320,6 @@ struct evsel *evlist__add_sched_switch(struct evlist *evlist, bool system_wide) 
}

#endif



struct evsel *evlist__find_tracepoint_by_id(struct evlist *evlist, int id)

{

	struct evsel *evsel;



	evlist__for_each_entry(evlist, evsel) {

		if (evsel->core.attr.type   == PERF_TYPE_TRACEPOINT &&

		    (int)evsel->core.attr.config == id)

			return evsel;

	}



	return NULL;

}



struct evsel *evlist__find_tracepoint_by_name(struct evlist *evlist, const char *name)

{

	struct evsel *evsel;
@@ -1157,11 +1144,6 @@ int evlist__set_tp_filter_pids(struct evlist *evlist, size_t npids, pid_t *pids) 
	return ret;

}



int evlist__set_tp_filter_pid(struct evlist *evlist, pid_t pid)

{

	return evlist__set_tp_filter_pids(evlist, 1, &pid);

}



int evlist__append_tp_filter_pids(struct evlist *evlist, size_t npids, pid_t *pids)

{

	char *filter = asprintf__tp_filter_pids(npids, pids);

tools/perf/util/evlist.h

+0 −2
Original line number Diff line number Diff line
@@ -132,7 +132,6 @@ int __evlist__set_tracepoints_handlers(struct evlist *evlist, 
	__evlist__set_tracepoints_handlers(evlist, array, ARRAY_SIZE(array))



int evlist__set_tp_filter(struct evlist *evlist, const char *filter);

int evlist__set_tp_filter_pid(struct evlist *evlist, pid_t pid);

int evlist__set_tp_filter_pids(struct evlist *evlist, size_t npids, pid_t *pids);



int evlist__append_tp_filter(struct evlist *evlist, const char *filter);
@@ -140,7 +139,6 @@ int evlist__append_tp_filter(struct evlist *evlist, const char *filter); 
int evlist__append_tp_filter_pid(struct evlist *evlist, pid_t pid);

int evlist__append_tp_filter_pids(struct evlist *evlist, size_t npids, pid_t *pids);



struct evsel *evlist__find_tracepoint_by_id(struct evlist *evlist, int id);

struct evsel *evlist__find_tracepoint_by_name(struct evlist *evlist, const char *name);



int evlist__add_pollfd(struct evlist *evlist, int fd);

tools/perf/util/trace-event-parse.c

+0 −6
Original line number Diff line number Diff line
@@ -116,12 +116,6 @@ void event_format__fprintf(struct tep_event *event, 
	trace_seq_destroy(&s);

}



void event_format__print(struct tep_event *event,

			 int cpu, void *data, int size)

{

	return event_format__fprintf(event, cpu, data, size, stdout);

}



/*

 * prev_state is of size long, which is 32 bits on 32 bit architectures.

 * As it needs to have the same bits for both 32 bit and 64 bit architectures

tools/perf/util/trace-event.h

+0 −3
Original line number Diff line number Diff line
@@ -42,9 +42,6 @@ struct tep_event *trace_event__tp_format_id(int id); 
void event_format__fprintf(struct tep_event *event,

			   int cpu, void *data, int size, FILE *fp);



void event_format__print(struct tep_event *event,

			 int cpu, void *data, int size);



int parse_ftrace_file(struct tep_handle *pevent, char *buf, unsigned long size);

int parse_event_file(struct tep_handle *pevent,

		     char *buf, unsigned long size, char *sys);