Commit 9afaaa54 authored by Jijie Shao's avatar Jijie Shao Committed by Jakub Kicinski
Browse files

net: hibmcge: fix incorrect multicast filtering issue 



The driver does not support multicast filtering,
the mask must be set to 0xFFFFFFFF. Otherwise,
incorrect filtering occurs.

This patch fixes this problem.

Fixes: 37b367d6 ("net: hibmcge: Add unicast frame filter supported in this module")
Signed-off-by: default avatarJijie Shao <shaojijie@huawei.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250410021327.590362-3-shaojijie@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5b04080c

drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c

+4 −0
Original line number Diff line number Diff line
@@ -234,6 +234,10 @@ void hbg_hw_set_mac_filter_enable(struct hbg_priv *priv, u32 enable) 
{

	hbg_reg_write_field(priv, HBG_REG_REC_FILT_CTRL_ADDR,

			    HBG_REG_REC_FILT_CTRL_UC_MATCH_EN_B, enable);



	/* only uc filter is supported, so set all bits of mc mask reg to 1 */

	hbg_reg_write64(priv, HBG_REG_STATION_ADDR_LOW_MSK_0, U64_MAX);

	hbg_reg_write64(priv, HBG_REG_STATION_ADDR_LOW_MSK_1, U64_MAX);

}



void hbg_hw_set_pause_enable(struct hbg_priv *priv, u32 tx_en, u32 rx_en)

drivers/net/ethernet/hisilicon/hibmcge/hbg_reg.h

+2 −0
Original line number Diff line number Diff line
@@ -135,6 +135,8 @@ 
#define HBG_REG_STATION_ADDR_HIGH_4_ADDR	(HBG_REG_SGMII_BASE + 0x0224)

#define HBG_REG_STATION_ADDR_LOW_5_ADDR		(HBG_REG_SGMII_BASE + 0x0228)

#define HBG_REG_STATION_ADDR_HIGH_5_ADDR	(HBG_REG_SGMII_BASE + 0x022C)

#define HBG_REG_STATION_ADDR_LOW_MSK_0		(HBG_REG_SGMII_BASE + 0x0230)

#define HBG_REG_STATION_ADDR_LOW_MSK_1		(HBG_REG_SGMII_BASE + 0x0238)



/* PCU */

#define HBG_REG_TX_FIFO_THRSLD_ADDR		(HBG_REG_SGMII_BASE + 0x0420)