Unverified Commit 9b0ee949 authored by Thorsten Blum's avatar Thorsten Blum Committed by Ilpo Järvinen
Browse files

platform/x86: dell-wmi-sysman: Use sysfs_emit{_at} in show functions 



Replace sprintf() with sysfs_emit() and sysfs_emit_at() in sysfs show
functions. sysfs_emit() and sysfs_emit_at() are preferred for formatting
sysfs output because they provide safer bounds checking.

In reset_bios_show(), use sysfs_emit_at() to avoid manual buffer size
accounting.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20260305140912.258090-2-thorsten.blum@linux.dev


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent d913a5a1

drivers/platform/x86/dell/dell-wmi-sysman/sysman.c

+7 −6
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@ 
#include <linux/dmi.h>

#include <linux/module.h>

#include <linux/kernel.h>

#include <linux/sysfs.h>

#include <linux/wmi.h>

#include "dell-wmi-sysman.h"

#include "../../firmware_attributes_class.h"
@@ -143,17 +144,17 @@ int map_wmi_error(int error_code) 
 */

static ssize_t reset_bios_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)

{

	char *start = buf;

	ssize_t len = 0;

	int i;



	for (i = 0; i < MAX_TYPES; i++) {

		if (i == reset_option)

			buf += sprintf(buf, "[%s] ", reset_types[i]);

			len += sysfs_emit_at(buf, len, "[%s] ", reset_types[i]);

		else

			buf += sprintf(buf, "%s ", reset_types[i]);

			len += sysfs_emit_at(buf, len, "%s ", reset_types[i]);

	}

	buf += sprintf(buf, "\n");

	return buf-start;

	len += sysfs_emit_at(buf, len, "\n");

	return len;

}



/**
@@ -194,7 +195,7 @@ static ssize_t reset_bios_store(struct kobject *kobj, 
static ssize_t pending_reboot_show(struct kobject *kobj, struct kobj_attribute *attr,

				   char *buf)

{

	return sprintf(buf, "%d\n", wmi_priv.pending_changes);

	return sysfs_emit(buf, "%d\n", wmi_priv.pending_changes);

}



static struct kobj_attribute reset_bios = __ATTR_RW(reset_bios);