Commit 9b1097a4 authored by Breno Leitao's avatar Breno Leitao Committed by Jakub Kicinski
Browse files

vxlan: Use nlmsg_payload in vxlan_vnifilter_dump 



Leverage the new nlmsg_payload() helper to avoid checking for message
size and then reading the nlmsg data.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250415-nlmsg_v2-v1-8-a1c75d493fd7@debian.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 04e00a84

drivers/net/vxlan/vxlan_vnifilter.c

+2 −3
Original line number Diff line number Diff line
@@ -411,13 +411,12 @@ static int vxlan_vnifilter_dump(struct sk_buff *skb, struct netlink_callback *cb 
	struct tunnel_msg *tmsg;

	struct net_device *dev;



	if (cb->nlh->nlmsg_len < nlmsg_msg_size(sizeof(struct tunnel_msg))) {

	tmsg = nlmsg_payload(cb->nlh, sizeof(*tmsg));

	if (!tmsg) {

		NL_SET_ERR_MSG(cb->extack, "Invalid msg length");

		return -EINVAL;

	}



	tmsg = nlmsg_data(cb->nlh);



	if (tmsg->flags & ~TUNNEL_MSG_VALID_USER_FLAGS) {

		NL_SET_ERR_MSG(cb->extack, "Invalid tunnelmsg flags in ancillary header");

		return -EINVAL;